feat(pn-13919): replace notification dto with model from bff (#1470)

pagopa · Feb 14, 2025 · 073a078 · 073a078
1 parent e8d7377
commit 073a078
Show file tree

Hide file tree

Showing 15 changed files with 205 additions and 307 deletions.
diff --git a/packages/pn-pa-webapp/src/__mocks__/NewNotification.mock.ts b/packages/pn-pa-webapp/src/__mocks__/NewNotification.mock.ts
@@ -1,20 +1,19 @@
 import {
-  DigitalDomicileType,
   PhysicalCommunicationType,
   RecipientType,
 } from '@pagopa-pn/pn-commons';
 
 import {
   NewNotification,
-  NewNotificationDTO,
+  NewNotificationDigitalAddressType,
   NewNotificationDocument,
   NewNotificationRecipient,
   NotificationFeePolicy,
   PaymentModel,
 } from '../models/NewNotification';
 import { UserGroup } from '../models/user';
-import { newNotificationMapper } from '../utility/notification.utility';
 import { userResponse } from './Auth.mock';
+import { BffNewNotificationRequest, NotificationDigitalAddressTypeEnum, NotificationDocument, NotificationRecipientV23 } from '../generated-client/notifications';
 
 export const newNotificationGroups: Array<UserGroup> = [
   {
@@ -43,7 +42,7 @@ const newNotificationRecipients: Array<NewNotificationRecipient> = [
     firstName: 'Mario',
     lastName: 'Rossi',
     recipientType: RecipientType.PF,
-    type: DigitalDomicileType.PEC,
+    type: NewNotificationDigitalAddressType.PEC,
     digitalDomicile: '[email protected]',
     address: 'via del corso',
     addressDetails: '',
@@ -61,7 +60,7 @@ const newNotificationRecipients: Array<NewNotificationRecipient> = [
     firstName: 'Sara Gallo srl',
     lastName: '',
     recipientType: RecipientType.PG,
-    type: DigitalDomicileType.PEC,
+    type: NewNotificationDigitalAddressType.PEC,
     digitalDomicile: '',
     address: 'via delle cicale',
     addressDetails: '',
@@ -74,6 +73,22 @@ const newNotificationRecipients: Array<NewNotificationRecipient> = [
   },
 ];
 
+const newNotificationRecipientsForBff: Array<NotificationRecipientV23> = [
+  {
+    taxId: 'MRARSS90P08H501Q',
+    denomination: 'Mario Rossi',
+    recipientType: RecipientType.PF,
+    digitalDomicile: {type: NotificationDigitalAddressTypeEnum.Pec,address: '[email protected]'},
+    physicalAddress: {address:'via del corso 49', zip: '00122', municipality: 'Roma', province: 'Roma', foreignState: 'Italia'},
+  },
+  {
+    taxId: '12345678901',
+    denomination: 'Sara Gallo srl',
+    recipientType: RecipientType.PG,
+    physicalAddress: {address:'via delle cicale 21', zip: '00035', municipality: 'Anzio', province: 'Roma', foreignState: 'Italia'}
+  },
+]
+
 const newNotificationDocuments: Array<NewNotificationDocument> = [
   {
     id: 'mocked-id-0',
@@ -115,6 +130,31 @@ const newNotificationDocuments: Array<NewNotificationDocument> = [
   },
 ];
 
+const newNotificationDocumentsForBff: Array<NotificationDocument> = [
+  {
+    title: 'mocked-name-0',
+    contentType: 'application/pdf',
+    digests: {
+      sha256: 'mocked-sha256-0',
+    },
+    ref: {
+      key: 'mocked-key-0',
+      versionToken: 'mocked-versionToken-0',
+    },
+  },
+  {
+    title: 'mocked-name-1',
+    contentType: 'application/pdf',
+    digests: {
+      sha256: 'mocked-sha256-1',
+    },
+    ref: {
+      key: 'mocked-key-1',
+      versionToken: 'mocked-versionToken-1',
+    },
+  },
+];
+
 const newNotificationPagoPa: NewNotificationDocument = {
   id: 'mocked-pagopa-id',
   idx: 0,
@@ -190,8 +230,21 @@ export const newNotificationEmpty: NewNotification = {
   paymentMode: '' as PaymentModel,
   group: '',
   taxonomyCode: '',
+  senderTaxId:'',
   notificationFeePolicy: '' as NotificationFeePolicy,
   senderDenomination: userResponse.organization.name,
 };
 
-export const newNotificationDTO: NewNotificationDTO = newNotificationMapper(newNotification);
+export const newNotificationForBff: BffNewNotificationRequest = {
+  abstract: '',
+  paProtocolNumber: '12345678910',
+  subject: 'Multone esagerato',
+  recipients: newNotificationRecipientsForBff,
+  documents: newNotificationDocumentsForBff,
+  physicalCommunicationType: PhysicalCommunicationType.REGISTERED_LETTER_890,
+  group: newNotificationGroups[2].id,
+  taxonomyCode: '010801N',
+  notificationFeePolicy: NotificationFeePolicy.FLAT_RATE,
+  senderDenomination: userResponse.organization.name,
+  senderTaxId: userResponse.organization.fiscal_code,
+};
diff --git a/packages/pn-pa-webapp/src/components/NewNotification/PreliminaryInformations.tsx b/packages/pn-pa-webapp/src/components/NewNotification/PreliminaryInformations.tsx
@@ -26,12 +26,12 @@ import { LangCode } from '@pagopa/mui-italia';
 import {
   NewNotification,
   NewNotificationLangOther,
+  PreliminaryInformationsPayload,
 } from '../../models/NewNotification';
 import { GroupStatus } from '../../models/user';
 import { useAppDispatch, useAppSelector } from '../../redux/hooks';
 import { NEW_NOTIFICATION_ACTIONS, getUserGroups } from '../../redux/newNotification/actions';
 import { setPreliminaryInformations } from '../../redux/newNotification/reducers';
-import { PreliminaryInformationsPayload } from '../../redux/newNotification/types';
 import { RootState } from '../../redux/store';
 import { getConfiguration } from '../../services/configuration.service';
 import { requiredStringFieldValidation } from '../../utility/validation.utility';

diff --git a/packages/pn-pa-webapp/src/components/NewNotification/PreliminaryInformationsContent.tsx b/packages/pn-pa-webapp/src/components/NewNotification/PreliminaryInformationsContent.tsx
@@ -5,8 +5,7 @@ import { useTranslation } from 'react-i18next';
 import { TextField, Typography, useFormControl } from '@mui/material';
 import { LangCode, LangLabels } from '@pagopa/mui-italia';
 
-import { NewNotificationLangOther } from '../../models/NewNotification';
-import { PreliminaryInformationsPayload } from '../../redux/newNotification/types';
+import { NewNotificationLangOther, PreliminaryInformationsPayload } from '../../models/NewNotification';
 import { FormBox, FormBoxSubtitle, FormBoxTitle } from './NewNotificationFormElelements';
 
 type SubjectFocusHelperTextProps = {

diff --git a/packages/pn-pa-webapp/src/components/NewNotification/PreliminaryInformationsLang.tsx b/packages/pn-pa-webapp/src/components/NewNotification/PreliminaryInformationsLang.tsx
@@ -14,8 +14,7 @@ import {
 import { CustomDropdown } from '@pagopa-pn/pn-commons';
 import { LangCode, LangLabels } from '@pagopa/mui-italia';
 
-import { BILINGUALISM_LANGUAGES, NewNotificationLangOther } from '../../models/NewNotification';
-import { PreliminaryInformationsPayload } from '../../redux/newNotification/types';
+import { BILINGUALISM_LANGUAGES, NewNotificationLangOther, PreliminaryInformationsPayload } from '../../models/NewNotification';
 import { FormBox, FormBoxSubtitle, FormBoxTitle } from './NewNotificationFormElelements';
 
 type Props = {

diff --git a/packages/pn-pa-webapp/src/components/NewNotification/Recipient.tsx b/packages/pn-pa-webapp/src/components/NewNotification/Recipient.tsx
@@ -14,10 +14,10 @@ import {
   Stack,
   Typography,
 } from '@mui/material';
-import { DigitalDomicileType, RecipientType, dataRegex } from '@pagopa-pn/pn-commons';
+import { RecipientType, dataRegex } from '@pagopa-pn/pn-commons';
 import { ButtonNaked } from '@pagopa/mui-italia';
 
-import { NewNotificationRecipient, PaymentModel } from '../../models/NewNotification';
+import { NewNotificationDigitalAddressType, NewNotificationRecipient, PaymentModel } from '../../models/NewNotification';
 import { useAppDispatch } from '../../redux/hooks';
 import { saveRecipients } from '../../redux/newNotification/reducers';
 import {
@@ -36,7 +36,7 @@ const singleRecipient = {
   taxId: '',
   firstName: '',
   lastName: '',
-  type: DigitalDomicileType.PEC,
+  type: NewNotificationDigitalAddressType.PEC,
   digitalDomicile: '',
   address: '',
   houseNumber: '',