Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VAS-812] feat: updates to pdf-engine #99

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

alessio-cialini
Copy link
Contributor

@alessio-cialini alessio-cialini commented Mar 7, 2024

List of Changes

  • Introduced title parameter for accessibility
  • Updated puppetteer/handlebar version
  • Removed unused dependencies
  • Updated helper to match pagopa-pdf-receipt-template updates
  • Updated unit tests

Motivation and Context

https://pagopa.atlassian.net/jira/software/c/projects/VAS/boards/540?selectedIssue=VAS-812

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

…ced title parameter for accessibility reasons
Copy link

github-actions bot commented Mar 7, 2024

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

Copy link

sonarqubecloud bot commented Mar 7, 2024

Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pasqualespica pasqualespica merged commit 4d1f6e2 into main Mar 8, 2024
10 of 12 checks passed
@jacopocarlini jacopocarlini deleted the VAS-812-feat-update-engine-function branch June 22, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants