Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(auth-service): [CHK-3743] update auth validate spec #2851

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

CianoDanilo
Copy link
Contributor

@CianoDanilo CianoDanilo commented Mar 3, 2025

List of changes

Removed 400 as a possible response code.

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

@CianoDanilo CianoDanilo requested review from a team as code owners March 3, 2025 16:35
Copy link
Contributor

@infantesimone infantesimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, remove the status code, but is it correct to expose this API on the APIM? Thinking about it, this API will only be used internally between APIM and the service, it is not used by checkout. I suggest removing this API from this group of APIs.

@CianoDanilo
Copy link
Contributor Author

Okay, remove the status code, but is it correct to expose this API on the APIM? Thinking about it, this API will only be used internally between APIM and the service, it is not used by checkout. I suggest removing this API from this group of APIs.

Done in cf1aa15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants