Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-2686] opex: Add error-codes #11

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

[PAGOPA-2686] opex: Add error-codes #11

wants to merge 16 commits into from

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Feb 26, 2025

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang self-assigned this Feb 26, 2025
"Error processing or sending data to event hub: %s. Details: %s",
flussoRendicontazione.getIdentificativoFlusso(), e.getMessage());
"[%s] Error processing or sending data to event hub: %s. Details: %s",
ErrorCodes.COMMON_E2, flussoRendicontazione.getIdentificativoFlusso(), e.getMessage());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[google-java-format] reported by reviewdog 🐶

Suggested change
ErrorCodes.COMMON_E2, flussoRendicontazione.getIdentificativoFlusso(), e.getMessage());
ErrorCodes.COMMON_E2,
flussoRendicontazione.getIdentificativoFlusso(),
e.getMessage());

Comment on lines +7 to +11
// Common Errors
COMMON_E1("FDR-E1", "Error while sending to EventHub."),
COMMON_E2("FDR-E2", "Error while process XML Blob."),
// FDR1 Errors
FDR1_E1("FDR1-E1", "Error processing Blob in processFDR1BlobFiles function");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[google-java-format] reported by reviewdog 🐶

Suggested change
// Common Errors
COMMON_E1("FDR-E1", "Error while sending to EventHub."),
COMMON_E2("FDR-E2", "Error while process XML Blob."),
// FDR1 Errors
FDR1_E1("FDR1-E1", "Error processing Blob in processFDR1BlobFiles function");
// Common Errors
COMMON_E1("FDR-E1", "Error while sending to EventHub."),
COMMON_E2("FDR-E2", "Error while process XML Blob."),
// FDR1 Errors
FDR1_E1("FDR1-E1", "Error processing Blob in processFDR1BlobFiles function");

// FDR1 Errors
FDR1_E1("FDR1-E1", "Error processing Blob in processFDR1BlobFiles function");


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[google-java-format] reported by reviewdog 🐶

Suggested change
private final String code;
private final String message;

Comment on lines +14 to +21
private final String code;
private final String message;

ErrorCodes(String code, String message) {
this.code = code;
this.message = message;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[google-java-format] reported by reviewdog 🐶

Suggested change
private final String code;
private final String message;
ErrorCodes(String code, String message) {
this.code = code;
this.message = message;
}
ErrorCodes(String code, String message) {
this.code = code;
this.message = message;
}

Copy link

This pull request does not contain a valid label. Please add one of the following labels: [major, minor, patch, patch, skip]

Comment on lines +16 to +17

import it.gov.pagopa.fdr.to.eventhub.util.ErrorCodes;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[google-java-format] reported by reviewdog 🐶

Suggested change
import it.gov.pagopa.fdr.to.eventhub.util.ErrorCodes;

"[FDR1] Error processing Blob '%s/%s': %s",
fdr1Container, blobName, e.getMessage()));
"[%s][FDR1] Error processing Blob '%s/%s': %s",
ErrorCodes.FDR1_E1, fdr1Container, blobName, e.getMessage()));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[google-java-format] reported by reviewdog 🐶

Suggested change
ErrorCodes.FDR1_E1, fdr1Container, blobName, e.getMessage()));
ErrorCodes.FDR1_E1, fdr1Container, blobName, e.getMessage()));

@cap-ang cap-ang marked this pull request as ready for review March 3, 2025 08:03
@cap-ang cap-ang requested a review from a team as a code owner March 3, 2025 08:03
Copy link

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants