Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove log mask feature falling back to the default ecs encoder #603

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

sfarralorenzo
Copy link
Contributor

List of Changes

We want to revert to plain logs without any data masking.

Motivation and Context

The masked logs behavior was originally introduced to protect sensitive data such as email addresses and card information. Since this data is no longer logged, masking is no longer necessary.

This change ensures all relevant data, such as transaction IDs, is fully visible in the logs for easier debugging and traceability.

How Has This Been Tested?

  • Updated unit tests
  • Checking logs in the local environment

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

infantesimone
infantesimone previously approved these changes Jan 17, 2025
@infantesimone
Copy link
Contributor

infantesimone commented Jan 17, 2025

un piccolo passo per l'uomo un grande passo per l'umanità

Copy link

sonarqubecloud bot commented Feb 3, 2025

@pietro-tota pietro-tota merged commit 5527bf3 into main Feb 4, 2025
7 checks passed
@pietro-tota pietro-tota deleted the chore-unmasked-logs branch February 4, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants