Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npg-apm): api keys configuration for APM #465

Merged
merged 15 commits into from
Apr 4, 2024

Conversation

pietro-tota
Copy link
Contributor

@pietro-tota pietro-tota commented Apr 3, 2024

Depends on pagopa/pagopa-infra#1889
Depends on pagopa/pagopa-ecommerce-local#157
Depends on pagopa/pagopa-ecommerce-commons#188

List of Changes

Add api keys configuration for NPG alternative payment methods (APM).
This PR integrate eCommerce commons NpgApiKeyHandler utility class to handle all NPG psp specific api keys

Motivation and Context

Those modifications are required in order to use the proper api key based on selected payment methods and psp id

How Has This Been Tested?

Junit tests + local tests with eCommerce local

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pietro-tota pietro-tota marked this pull request as ready for review April 3, 2024 13:28
@pietro-tota pietro-tota requested a review from a team as a code owner April 3, 2024 13:28
Copy link

dpulls bot commented Apr 4, 2024

🎉 All dependencies have been resolved !

giovanniberti
giovanniberti previously approved these changes Apr 4, 2024
Copy link

sonarqubecloud bot commented Apr 4, 2024

@pietro-tota pietro-tota merged commit 258dfe1 into main Apr 4, 2024
7 checks passed
@pietro-tota pietro-tota deleted the CHK-2684-apm-api-keys branch April 4, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants