feat(nodo): CHK-1930 add apy-key for auth nodo ws #328
Conversation
|
Depends pagopa/pagopa-ecommerce-local#98 |
infantesimone
changed the title
| @@ -76,7 +76,7 @@ microservice-chart: | |||
| REDIS_PORT: "6380" | |||
| REDIS_SSL_ENABLED: "true" | |||
| NODO_HOSTNAME: https://api.dev.platform.pagopa.it | |||
| NODE_FOR_PSP_URI: /nodo/node-for-psp/v1 | |||
| NODE_FOR_PSP_URI: /nodo-auth/node-for-psp/v1 | |||
There was a problem hiding this comment.
Missing NODO_NODEFORPSP_API_KEY and NODO_CLOSEPAYMENT_API_KEY env secrets?
| @@ -32,6 +32,12 @@ public class NodeForPspClient { | |||
| @Value("${nodo.nodeforpsp.uri}") | |||
| private String nodoPerPspUri; | |||
|
|
|||
| @Value("${nodo.nodeforpsp.apikey}") | |||
There was a problem hiding this comment.
Maybe here we can refactor this class to use constructor injection? what do you think? this way we can avoid reflection to set those api key into test class
There was a problem hiding this comment.
right, but better to do it in a dedicated PR
|
SonarCloud Quality Gate failed.
|
| @@ -81,10 +88,11 @@ public Mono<ClosePaymentResponseDto> closePaymentV2(ClosePaymentRequestV2Dto req | |||
| ); | |||
| return nodoWebClient.post() | |||
| .uri( | |||
| uriBuilder -> uriBuilder.path("/nodo/nodo-per-pm/v2/closepayment") | |||
| uriBuilder -> uriBuilder.path("/nodo-auth/nodo-per-pm/v2/closepayment") | |||
There was a problem hiding this comment.
I would parameterized (maybe in another PR) this path in order to change it's value upgrading helm instead of modifying code. What do you think?
|
Please remember to make a PR for environments alignment against https://github.com/pagopa/pagopa-ecommerce-local |
List of Changes
Motivation and Context
The goal of this PR is to update nodo basepath in order to call node ws with api key:
Node for PSP WS (NM3) (AUTH)Nodo per Payment Manager API (AUTH)How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: