chore: [IOBP-667,IOBP-666] Adapt user wallet definitions with the new openapi #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 69.66% 69.66%
=======================================
Files 156 156
Lines 5008 5008
Branches 605 605
=======================================
Hits 3489 3489
+ Misses 1518 1441 -77
- Partials 1 78 +77
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mastro993
approved these changes
Jun 4, 2024
Hantex9
added a commit
to pagopa/io-app
that referenced
this pull request
Jun 4, 2024
…thod adaption (#5803) ## Short description This PR adds the metadata for fast PayPal payment by adding the masked email and the pspBusinessName if both are present. In addition, the selector has been adapted to handle the “recently used” logic by taking into account the `lastUsage` attribute of the `clients` map ## List of changes proposed in this pull request - Upgraded the new openapi for wallet & ecommerce - Changed the selector to filter the "recently used" payment method following the new openapi definitions - Added metadata to the "Pagamento veloce con PayPal" with the pspBusinessName and maskedEmail if both present. ## How to test - Checkout this PR: pagopa/io-dev-api-server#384 - Start a new payment and when you are in the payment selection step, you should be able to see a pre-selected method. If in the list of saved methods or the "recently used" there is a "Pagamento veloce con PayPal", you should be able even to see metadata in the list item description ## Preview <img src="https://github.com/pagopa/io-app/assets/34343582/f2dcd4ae-276d-4f32-b6bf-81fd75911ca3" width="350px" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adapts the new user wallet definition upgrading the openapi file
List of changes proposed in this pull request
PAYPALadding the new pspBusinessName metadataclientsattribute with theIOkey;How to test
Try this PR combined with this other PR on the io-app: pagopa/io-app#5803 , you should be able to see a pre-selected payment method and if it is a "Pagamento veloce con PayPal", you should be able to see also the email and PSP name.