Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOCOM-1436] Services and Organizations random logos #381

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR adds random logos for services and organizations.

List of changes proposed in this pull request

  • Two lists of services and organizations file logos have been added
  • On both endpoints (static_contents/logos/services/service_id and static_contents/logos/organizations/organization_id), on the first time, logo image is picked randomly from related file list. Subsequent requests to the same resource return the same file
  • Special services (SEND and CGN) requests always return their own logo
  • Enriched message response includes the organization fiscal code (in order to support fallback on message home list)

How to test

Call both enpoints above and check that the same logo is returned for subsequent requests (apart from restarting the server instance). Check that both SEND and CGN always return their own logo

@Vangaorth
Copy link
Contributor Author

@adelloste

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 69.87%. Comparing base (d97d986) to head (4837312).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   69.65%   69.87%   +0.21%     
==========================================
  Files         153      153              
  Lines        4845     4886      +41     
  Branches      555      583      +28     
==========================================
+ Hits         3375     3414      +39     
+ Misses       1469     1395      -74     
- Partials        1       77      +76     
Files Coverage Δ
src/features/messages/services/messagesService.ts 58.01% <ø> (ø)
src/populate-persistence.ts 83.70% <100.00%> (+0.18%) ⬆️
src/utils/file.ts 48.07% <100.00%> (+6.77%) ⬆️
src/routers/services_metadata.ts 60.44% <92.50%> (+10.94%) ⬆️

... and 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af1b8c7...4837312. Read the comment docs.

Fixed service and organization logo retrieval endpoint which use the filename with extension instead of the service/organization id
@Vangaorth Vangaorth merged commit 140c973 into master May 22, 2024
8 checks passed
@Vangaorth Vangaorth deleted the IOCOM-1436 branch February 13, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants