Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Show error numbers in login.html #380

Merged
merged 2 commits into from
May 23, 2024

Conversation

shadowsheep1
Copy link
Member

@shadowsheep1 shadowsheep1 commented May 21, 2024

Short description

This PR shows the error number inside the dropdown list item description too.

How to test

Run the app against the dev server and check the error dropdown list.

Details

@shadowsheep1 shadowsheep1 requested a review from a team as a code owner May 21, 2024 12:35
@shadowsheep1 shadowsheep1 self-assigned this May 21, 2024
@shadowsheep1 shadowsheep1 added the IO-A&I IO - Autenticazione e Identità label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (d97d986) to head (424cb0a).
Report is 2 commits behind head on master.

Current head 424cb0a differs from pull request most recent head 54c1d40

Please upload reports for the commit 54c1d40 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #380   +/-   ##
=======================================
  Coverage   69.65%   69.65%           
=======================================
  Files         153      153           
  Lines        4845     4845           
  Branches      555      555           
=======================================
  Hits         3375     3375           
  Misses       1469     1469           
  Partials        1        1           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 140c973...54c1d40. Read the comment docs.

Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shadowsheep1 shadowsheep1 merged commit 59d1cfd into master May 23, 2024
6 checks passed
@shadowsheep1 shadowsheep1 deleted the show-error-numbers-in-login-html branch May 23, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants