Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SPID logo retrieval #374

Merged
merged 2 commits into from
May 3, 2024
Merged

fix: SPID logo retrieval #374

merged 2 commits into from
May 3, 2024

Conversation

shadowsheep1
Copy link
Member

@shadowsheep1 shadowsheep1 commented Apr 30, 2024

Short description

This PR adds missing SPID provider logos and fixes the retrieval them.

How to test

Uninstall App IO if previously installed. Try a SPID login with App IO. In the SPID IdP selection screen you should see all providers logo.

Demo

@shadowsheep1 shadowsheep1 requested a review from a team as a code owner April 30, 2024 16:09
@shadowsheep1 shadowsheep1 self-assigned this May 2, 2024
@shadowsheep1 shadowsheep1 added the IO-A&I IO - Autenticazione e Identità label May 2, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.02%. Comparing base (16809ea) to head (38bda48).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   70.06%   70.02%   -0.05%     
==========================================
  Files         151      151              
  Lines        4791     4794       +3     
  Branches      552      573      +21     
==========================================
  Hits         3357     3357              
+ Misses       1433     1363      -70     
- Partials        1       74      +73     
Files Coverage Δ
src/routers/services_metadata.ts 49.50% <0.00%> (-1.52%) ⬇️

... and 23 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 465d53c...38bda48. Read the comment docs.

Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shadowsheep1 shadowsheep1 merged commit 80403a4 into master May 3, 2024
8 checks passed
@Vangaorth Vangaorth deleted the fix-spid-images branch February 13, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants