[IOBP-45,IOBP-75,IOBP-494] Remove Bonus Cashback, Bonus Vacanze and Sicilia Vola features

[mastro993]

Short description

This PR removes everything related to Bonus Cashback, Bonus Vacanze and Sicilia Vola features

How to test

Tests should solve correclty

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (182ec31) 67.44% compared to head (bc5966b) 70.59%.
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   67.44%   70.59%   +3.15%     
==========================================
  Files         156      141      -15     
  Lines        5265     4629     -636     
  Branches      636      563      -73     
==========================================
- Hits         3551     3268     -283     
+ Misses       1615     1290     -325     
+ Partials       99       71      -28     

Files	Coverage Δ
src/config.ts	96.00% <ø> (ø)
src/features/wallet/payloads/transactions.ts	60.00% <ø> (ø)
src/persistence/services.ts	86.95% <ø> (-0.19%)	⬇️
src/populate-persistence.ts	83.52% <ø> (ø)
src/routers/features/cgn/index.ts	32.59% <100.00%> (ø)
src/routers/public.ts	67.46% <ø> (-0.51%)	⬇️
src/routers/services_metadata.ts	51.02% <ø> (+1.48%)	⬆️
src/server.ts	100.00% <ø> (ø)
src/types/config.ts	100.00% <ø> (ø)
src/utils/variables.ts	100.00% <ø> (ø)
... and 2 more

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9754d2...bc5966b. Read the comment docs.

[forrest57]

while this PR gets the job done, there still are some --surely unused-- references of BPD and BV around the project.
Since this is an "internal" project, we could very well ignore this and keep going, but I'm not 100% on this; what do you think? @mastro993

[mastro993]

while this PR gets the job done, there still are some --surely unused-- references of BPD and BV around the project. Since this is an "internal" project, we could very well ignore this and keep going, but I'm not 100% on this; what do you think? @mastro993

What are these references?

[forrest57]

while this PR gets the job done, there still are some --surely unused-- references of BPD and BV around the project. Since this is an "internal" project, we could very well ignore this and keep going, but I'm not 100% on this; what do you think? @mastro993

What are these references?

there still is the bpd_ranking field in backend.ts, also in configDashboard.ts; overall with a full project search, the bpd word pops up quite a bunch of time, even if used wrongly (101 in 17 files to be exact).
BV is referenced mainly in specs_functions.yaml, bonus_available.json, public.ts, services_metadata.ts and variables.ts, with a full search on vacanze around the app resulting in 64 results in 11 files.

As I already said, no biggie if we let it in, since it's all an "internal" thing, better to have a bit more than a bit less; but still if we fully want to remove those two I think those parts should be touched on.

[mastro993]

while this PR gets the job done, there still are some --surely unused-- references of BPD and BV around the project. Since this is an "internal" project, we could very well ignore this and keep going, but I'm not 100% on this; what do you think? @mastro993

What are these references?

there still is the bpd_ranking field in backend.ts, also in configDashboard.ts; overall with a full project search, the bpd word pops up quite a bunch of time, even if used wrongly (101 in 17 files to be exact). BV is referenced mainly in specs_functions.yaml, bonus_available.json, public.ts, services_metadata.ts and variables.ts, with a full search on vacanze around the app resulting in 64 results in 11 files.

As I already said, no biggie if we let it in, since it's all an "internal" thing, better to have a bit more than a bit less; but still if we fully want to remove those two I think those parts should be touched on.

See 18a941e

[forrest57]

@mastro993 almost done, bonusVacanze still pops up in src/routers/public.ts, line 152 and
for BPD we still have:

• payloads/backend.ts
• walletsV2/configDashboard.ts
• walletsV2/index.ts
• walletsV2/methods/bancomat.ts
• utils/variables.ts maybe? not sure about this one

once again, in some places "bpd" is just a buzzword that is thrown around, but still I think it should be at least renamed in order to completely remove BPD from the app/devServer.

also, by removing those you can remove a bunch of things, like the resetProfile handler, so we end up with an even tidier structure

[mastro993]

@mastro993 almost done, bonusVacanze still pops up in src/routers/public.ts, line 152 and for BPD we still have:

• payloads/backend.ts
• walletsV2/configDashboard.ts
• walletsV2/index.ts
• walletsV2/methods/bancomat.ts
• utils/variables.ts maybe? not sure about this one

once again, in some places "bpd" is just a buzzword that is thrown around, but still I think it should be at least renamed in order to completely remove BPD from the app/devServer.

also, by removing those you can remove a bunch of things, like the resetProfile handler, so we end up with an even tidier structure

As you said, BPD (Bonus Pagamenti Digitali) is a word used to reference to everything related to bonuses (ID Pay, CGN, and so on...), it's not always linked to the Cashback bonus. 😀

In those files BPD is used as flag to indicate if payment methods have BPD capabilities (like ID Pay), and sometimes is used with no references to BPD (bad naming, I guess?).