Skip to content

Commit

Permalink
SameSite policy for browser debugging
Browse files Browse the repository at this point in the history
  • Loading branch information
Vangaorth committed Apr 8, 2024
1 parent 1d57a0c commit fe53639
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions src/features/fims/routers/providerRouter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ const sessionTTLMilliseconds = () => 1 * 60 * 1000;
// TODO move to Config file
const jwtTTLMilliseconds = () => 15 * 60 * 1000;
// TODO move to Config file
const useLaxInsteadOfNoneForSessionCookieSameSite = () => true;
export const jwtSigningAlgorithm = () => "ES256K";
// TODO move to Config file
const jwtRawPrivateKey = () =>
Expand Down Expand Up @@ -732,13 +733,13 @@ addHandler(
.cookie(sessionCookieKey(), sessionData.session, {
path: `/fims/provider`,
expires: sessionCookieExpirationTime,
sameSite: "none",
sameSite: sameSitePolicyForSessionCookie(),
httpOnly: true
})
.cookie(sessionSignatyreCookieKey(), sessionData.sessionSignature, {
path: `/fims/provider`,
expires: sessionCookieExpirationTime,
sameSite: "none",
sameSite: sameSitePolicyForSessionCookie(),
httpOnly: true
})
.cookie(sessionLegacyCookieKey(), sessionData.sessionLegacy, {
Expand Down Expand Up @@ -910,13 +911,13 @@ addHandler(
.cookie(sessionCookieKey(), newSessionId, {
path: `/fims/provider`,
expires: sessionCookieExpirationTime,
sameSite: "none",
sameSite: sameSitePolicyForSessionCookie(),
httpOnly: true
})
.cookie(sessionSignatyreCookieKey(), v4(), {
path: `/fims/provider`,
expires: sessionCookieExpirationTime,
sameSite: "none",
sameSite: sameSitePolicyForSessionCookie(),
httpOnly: true
})
.cookie(sessionLegacyCookieKey(), newSessionId, {
Expand Down Expand Up @@ -987,3 +988,6 @@ const validateFIMSToken = (cookies: Record<string, unknown>, res: Response) => {
}
return true;
};

const sameSitePolicyForSessionCookie = () =>
useLaxInsteadOfNoneForSessionCookieSameSite() ? "lax" : "none";

0 comments on commit fe53639

Please sign in to comment.