add featuredItemsSize config param

pagopa · Apr 23, 2024 · d9e0208 · d9e0208
1 parent 5c73199
commit d9e0208
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/src/config.ts b/src/config.ts
@@ -190,6 +190,7 @@ const defaultConfig: IoDevServerConfig = {
       sessionTTLinMS: 60000
     },
     service: {
+      featuredItemsSize: 5,
       response: {
         featuredItemsResponseCode: 200,
         institutionsResponseCode: 200

diff --git a/src/features/services/payloads/get-featured-items.ts b/src/features/services/payloads/get-featured-items.ts
@@ -1,12 +1,15 @@
 import { nonEmptyArray } from "fp-ts";
-import * as A from "fp-ts/Array";
+import * as A from "fp-ts/lib/Array";
 import * as O from "fp-ts/lib/Option";
 import { pipe } from "fp-ts/lib/function";
 import { FeaturedItem } from "../../../../generated/definitions/services/FeaturedItem";
 import { FeaturedItems } from "../../../../generated/definitions/services/FeaturedItems";
+import { ioDevServerConfig } from "../../../config";
 import ServicesDB from "../../../persistence/services";
 import { getInstitutionsResponsePayload } from "./get-institutions";
 
+const featuredItemsSize = ioDevServerConfig.features.service.featuredItemsSize;
+
 /**
  * Returns a random ordered array subset.
  * @param array starting array of type T
@@ -16,7 +19,7 @@ import { getInstitutionsResponsePayload } from "./get-institutions";
 const getRandomArraySubset = <T>(array: T[], size: number): T[] =>
   pipe(
     O.some(array),
-    O.fromPredicate(arr => O.isSome(arr) && size <= array.length),
+    O.fromPredicate(arr => O.isSome(arr) && size > 0 && size <= array.length),
     O.fold(
       () => [],
       () => {
@@ -92,7 +95,7 @@ export const getFeaturedItemsResponsePayload = (): FeaturedItems => {
       ...featuredIntitutions,
       ...featuredNationalServices
     ],
-    arr => getRandomArraySubset(arr, arr.length)
+    arr => getRandomArraySubset(arr, featuredItemsSize)
   );
 
   return {

diff --git a/src/features/services/types/configuration.ts b/src/features/services/types/configuration.ts
@@ -1,9 +1,12 @@
+import { WithinRangeNumber } from "@pagopa/ts-commons/lib/numbers";
 import * as t from "io-ts";
 import { HttpResponseCode } from "../../../types/httpResponseCode";
 
-export const ServiceConfiguration = t.interface({
+export const ServiceConfiguration = t.type({
+  // configure number of featured items
+  featuredItemsSize: WithinRangeNumber(0, 6),
   // configure some API response error code
-  response: t.interface({
+  response: t.type({
     // 200 success with payload
     featuredItemsResponseCode: HttpResponseCode,
     institutionsResponseCode: HttpResponseCode