Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:[IOCOM-2205] PN engagement banner logic #6788

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

forrest57
Copy link
Contributor

Short description

addition of logic and required tests for PN's engagement banner flow

List of changes proposed in this pull request

  • updated definitions
  • added navigation to new flow, with navigator entry
  • addition of the screen itself, which handles the whole flow
  • required selector
  • required tests

How to test

using the dev-server (specifically this branch ):

  • set a delay on the dev-server (1500 was used during development)
  • disable SEND from the services tab
  • enable the banner in its visibility map
  • interact with the banner and make sure the flow is " loading data -> awaiting input (CTA shown) -> loading activation (on cta tap) -> success"
  • on future interactions, the flow should be "loading data -> already active"
  • disable SEND again and make sure everything is as expected
  • while already covered by automated tests, make sure the error pages work as intended.

Copy link
Contributor

github-actions bot commented Mar 5, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 29.31034% with 41 lines in your changes missing coverage. Please review.

Project coverage is 36.81%. Comparing base (f591e0a) to head (995f127).

Files with missing lines Patch % Lines
ts/features/pn/screens/PnReminderBannerFlow.tsx 18.00% 41 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f591e0a) and HEAD (995f127). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (f591e0a) HEAD (995f127)
7 5
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6788      +/-   ##
==========================================
- Coverage   46.40%   36.81%   -9.60%     
==========================================
  Files        1453     1551      +98     
  Lines       30546    32230    +1684     
  Branches     6913     7268     +355     
==========================================
- Hits        14176    11865    -2311     
- Misses      16320    20311    +3991     
- Partials       50       54       +4     
Files with missing lines Coverage Δ
...tures/pn/components/PNActivationReminderBanner.tsx 100.00% <100.00%> (+50.00%) ⬆️
ts/features/pn/navigation/navigator.tsx 66.66% <ø> (ø)
ts/features/pn/navigation/routes.ts 100.00% <ø> (ø)
ts/store/reducers/backendStatus/remoteConfig.ts 61.06% <100.00%> (+12.63%) ⬆️
ts/features/pn/screens/PnReminderBannerFlow.tsx 18.00% <18.00%> (ø)

... and 651 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f591e0a...995f127. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant