Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPID-2797] Add LoginExpirationBanner events #6786

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

ChrisMattew
Copy link
Collaborator

@ChrisMattew ChrisMattew commented Mar 5, 2025

Short description

This PR integrates some LoginExpirationBanner events

List of changes proposed in this pull request

  • Added the trackLoginExpirationBannerPrompt event tracked whenever the LoginExpirationBanner is prompted
  • Added the trackLoginExpirationBannerClosure event tracked when the LoginExpirationBanner is closed

Demo

login-expiration-banner-events.mov

Events in detail

BANNER CLOSE_BANNER

How to test

Follow the steps showed in the Demo and ensure that the events are correctly sent

@ChrisMattew ChrisMattew requested review from gispada, freddi301 and a team as code owners March 5, 2025 10:22
@ChrisMattew ChrisMattew self-assigned this Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@ChrisMattew ChrisMattew added the IO-A&I IO - Autenticazione e Identità label Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 50.97%. Comparing base (087c872) to head (3fa3bee).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/login/preferences/analytics/index.ts 33.33% 4 Missing ⚠️
...n/preferences/components/LoginExpirationBanner.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6786      +/-   ##
==========================================
- Coverage   50.98%   50.97%   -0.01%     
==========================================
  Files        1577     1578       +1     
  Lines       32675    32683       +8     
  Branches     7351     7354       +3     
==========================================
+ Hits        16659    16660       +1     
- Misses      15971    15978       +7     
  Partials       45       45              
Files with missing lines Coverage Δ
...n/preferences/components/LoginExpirationBanner.tsx 11.76% <0.00%> (-8.24%) ⬇️
ts/features/login/preferences/analytics/index.ts 33.33% <33.33%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087c872...3fa3bee. Read the comment docs.

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants