-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOPID-2797] Add LoginExpirationBanner
events
#6786
Conversation
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6786 +/- ##
==========================================
- Coverage 50.98% 50.97% -0.01%
==========================================
Files 1577 1578 +1
Lines 32675 32683 +8
Branches 7351 7354 +3
==========================================
+ Hits 16659 16660 +1
- Misses 15971 15978 +7
Partials 45 45
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR integrates some
LoginExpirationBanner
eventsList of changes proposed in this pull request
trackLoginExpirationBannerPrompt
event tracked whenever theLoginExpirationBanner
is promptedtrackLoginExpirationBannerClosure
event tracked when theLoginExpirationBanner
is closedDemo
login-expiration-banner-events.mov
Events in detail
BANNER
CLOSE_BANNER
How to test
Follow the steps showed in the Demo and ensure that the events are correctly sent