Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-1190] Add a11y announcement inside the payment method details screen #6776

Merged

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Mar 3, 2025

Short description

This PR adds a more detailed a11y announcement when opening the payment method details screen.

List of changes proposed in this pull request

  • Added an announcement with the useOnFirstRender hook to announce the detailed description of the screen;
  • Added the ignoreAccessibilityCheck in the useHeaderSecondLevel hook;

How to test

With the SR enabled, open the payment method details screen from the "Wallet" section and check that the detailed description is correctly announced

@Hantex9 Hantex9 added a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti labels Mar 3, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.95%. Comparing base (4653284) to head (52cb6e7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...nents/PaymentsMethodDetailsBaseScreenComponent.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6776      +/-   ##
==========================================
- Coverage   50.96%   50.95%   -0.01%     
==========================================
  Files        1578     1578              
  Lines       32697    32699       +2     
  Branches     7366     7416      +50     
==========================================
  Hits        16663    16663              
+ Misses      15987    15978       -9     
- Partials       47       58      +11     
Files with missing lines Coverage Δ
ts/hooks/useHeaderSecondLevel.tsx 96.96% <ø> (ø)
...nents/PaymentsMethodDetailsBaseScreenComponent.tsx 13.63% <0.00%> (-1.37%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4653284...52cb6e7. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hantex9 Hantex9 enabled auto-merge March 6, 2025 08:27
@Hantex9 Hantex9 added this pull request to the merge queue Mar 6, 2025
Merged via the queue into master with commit c69bce7 Mar 6, 2025
22 checks passed
@Hantex9 Hantex9 deleted the IOBP-1190-add-a11y-announcement-into-card-details-screen branch March 6, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants