Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-1186,IOBP-1187] Add a11y announcement when sorting the PSP list #6775

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Mar 3, 2025

⚠️ This PR depends on the release of the following PR: pagopa/io-app-design-system#421 ⚠️

Short description

This PR adds the a11y feature announcement when sorting the PSP list and added a more detailed accessibility label on the radio items showing the order type.

List of changes proposed in this pull request

  • Updated the io-app-design-system with the accessibilityLabel prop to the RadioItem (v5.0.5)
  • Added a present wrapper function inside the useSortPspBottomSheet that announces the a11y description;
  • Added a more detailed accessibilityLabel on every radio item;
  • Fixed a UI regression inside the WalletPaymentMakeScreen setting the flex prop to the View encapsulated inside the PagerView

How to test

  • Be sure that you installed the recent version of the design system running yarn install;
  • With the SR enabled, start a payment until you reach the PSP selection screen;
  • Tap the Sort CTA and check that the description is announced correctly;
  • Tap on every radio item available in the bottom sheet and check that the description is correctly announced;

@Hantex9 Hantex9 added a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti labels Mar 3, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.98%. Comparing base (f591e0a) to head (f7b8583).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../payments/checkout/hooks/useSortPspBottomSheet.tsx 71.42% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6775      +/-   ##
==========================================
+ Coverage   46.40%   50.98%   +4.57%     
==========================================
  Files        1453     1578     +125     
  Lines       30546    32691    +2145     
  Branches     6913     7407     +494     
==========================================
+ Hits        14176    16666    +2490     
+ Misses      16320    15979     -341     
+ Partials       50       46       -4     
Files with missing lines Coverage Δ
...ments/checkout/screens/WalletPaymentMakeScreen.tsx 10.00% <ø> (ø)
.../payments/checkout/hooks/useSortPspBottomSheet.tsx 85.71% <71.42%> (+3.89%) ⬆️

... and 324 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e3fed...f7b8583. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants