Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPID-2798] Add new copy on logout alert if there is an active wallet instance #6772

Merged
merged 10 commits into from
Mar 5, 2025

Conversation

Ladirico
Copy link
Contributor

@Ladirico Ladirico commented Mar 3, 2025

Short description

In this PR, a new copy was added in the alert that is shown in the logout screen to be shown to users who have the wallet instance active

Demo

With active Wallet instance Without active Wallet instance (as-is)
wi_active_alert_logout.mov
not_wi_alert_logout_asis.mov

How to test

  1. Run the application
  2. To test the behavior with or without an active wallet instance, manually modify the value of itwLifecycleIsOperationalOrValid:
  • Set to true if you need an active wallet instance.
  • Set to false if you want to test the flow without a wallet instance.

@Ladirico Ladirico added the IO-A&I IO - Autenticazione e Identità label Mar 3, 2025
@Ladirico Ladirico requested a review from shadowsheep1 March 3, 2025 11:17
@Ladirico Ladirico self-assigned this Mar 3, 2025
@Ladirico Ladirico requested review from ChrisMattew, gispada, freddi301 and a team as code owners March 3, 2025 11:17
Copy link
Contributor

github-actions bot commented Mar 3, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Mar 3, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 44.00%. Comparing base (087c872) to head (aebbd63).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ts/screens/profile/ProfileMainScreen.tsx 0.00% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (087c872) and HEAD (aebbd63). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (087c872) HEAD (aebbd63)
10 6
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6772      +/-   ##
==========================================
- Coverage   50.98%   44.00%   -6.98%     
==========================================
  Files        1577     1444     -133     
  Lines       32675    30380    -2295     
  Branches     7351     6811     -540     
==========================================
- Hits        16659    13370    -3289     
- Misses      15971    16974    +1003     
+ Partials       45       36       -9     
Files with missing lines Coverage Δ
ts/screens/profile/ProfileMainScreen.tsx 7.81% <0.00%> (-54.90%) ⬇️

... and 372 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087c872...aebbd63. Read the comment docs.

@Ladirico Ladirico added this pull request to the merge queue Mar 5, 2025
Merged via the queue into master with commit f591e0a Mar 5, 2025
22 checks passed
@Ladirico Ladirico deleted the IOPID-2798-bottomsheet-logout branch March 5, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants