Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-1164] Add a11y description to the receipt PDF preview page #6730

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Feb 18, 2025

Short description

This PR adds a view wrapper with an accessibility label that describes that there is displayed a pdf receipt in that screen.

List of changes proposed in this pull request

  • Added a11y description label to a view that wraps the Pdf preview.

How to test

With a real device (particularly Android), open a receipt detail and go inside the receipt preview screen.

Preview

Before After
before.webm
after.webm

@Hantex9 Hantex9 added a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti labels Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.96%. Comparing base (f2db628) to head (cd813d0).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6730   +/-   ##
=======================================
  Coverage   45.96%   45.96%           
=======================================
  Files        1433     1433           
  Lines       30401    30401           
  Branches     6891     6891           
=======================================
  Hits        13975    13975           
  Misses      16380    16380           
  Partials       46       46           
Files with missing lines Coverage Δ
...payments/receipts/screens/ReceiptPreviewScreen.tsx 4.34% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2db628...cd813d0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants