Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPID-2663] Updated the banner copy on the IdP selection page #6717

Closed
wants to merge 4 commits into from
Closed

chore: [IOPID-2663] Updated the banner copy on the IdP selection page #6717

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7dec0e
chore: update banner copy
shadowsheep1 Feb 14, 2025
0e99c93
Merge branch 'master' into IOPID-2663
Ladirico Feb 14, 2025
b60fedf
wip: delete locale *.yml files to avoid merge conflict
shadowsheep1 Feb 21, 2025
880edc4
Merge branch 'master' into IOPID-2663
shadowsheep1 Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions ts/screens/authentication/IdpSelectionScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import { IdpData } from "../../../definitions/content/IdpData";
import { nativeLoginSelector } from "../../features/nativeLogin/store/reducers";
import { isNativeLoginEnabledSelector } from "../../features/nativeLogin/store/selectors";
import { isFastLoginEnabledSelector } from "../../features/fastLogin/store/selectors";
import { useOnFirstRender } from "../../utils/hooks/useOnFirstRender";
import IdpsGrid from "../../components/IdpsGrid";
import { useHeaderSecondLevel } from "../../hooks/useHeaderSecondLevel";
Expand Down Expand Up @@ -77,9 +76,6 @@
const idps = useIOSelector(idpsRemoteValueSelector);
const assistanceToolConfig = useIOSelector(assistanceToolConfigSelector);
const nativeLoginFeature = useIOSelector(nativeLoginSelector);
const isFastLoginFeatureFlagEnabled = useIOSelector(
isFastLoginEnabledSelector
);
const isNativeLoginFeatureFlagEnabled = useIOSelector(
isNativeLoginEnabledSelector
);
Expand Down Expand Up @@ -184,11 +180,7 @@
viewRef={viewRef}
color="neutral"
size="small"
content={
isFastLoginFeatureFlagEnabled
? I18n.t("login.expiration_info_FL")
: I18n.t("login.expiration_info")
}
content={I18n.t("authentication.idp_selection.bannerDefaultInfo")}

Check failure on line 183 in ts/screens/authentication/IdpSelectionScreen.tsx

View workflow job for this annotation

GitHub Actions / static-checks 

Argument of type '"authentication.idp_selection.bannerDefaultInfo"' is not assignable to parameter of type 'TranslationKeys'.
pictogramName="passcode"
/>
</Pressable>
Expand Down
Loading