Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [IOPLT-784] Request App feedback to user #6617

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

feat: [IOPLT-784] Request App feedback to user #6617

wants to merge 42 commits into from
+5,875 −5,412

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Jan 20, 2025 •
edited
Loading

Note

This PR depends on pagopa/io-services-metadata#928

Short description

This PR implements the new feature to let the user give a feedback on pre-defined survey during specific flows

List of changes proposed in this pull request

  • Handle the new remote config for app feedback
  • Implements the hook to handle the logic of alert presentation
  • Handle the store and persist of last given feedback log
  • Changes the previously implemented callback trigger to ask for review only on device app store

How to test

Check the specific playground under Settings > Developer mode > Playgrounds > App feedback playground
Use pagopa/io-dev-api-server#464 to test

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-05.at.16.36.44.mp4

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to Jira issues:

@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.19048% with 46 lines in your changes missing coverage. Please review.

Project coverage is 42.70%. Comparing base (86fdf44) to head (3e2d0fe).

Files with missing lines Patch % Lines
.../features/appReviews/hooks/useAppReviewRequest.tsx 50.00% 14 Missing ⚠️
...eens/profile/playgrounds/AppFeedbackPlayground.tsx 9.09% 10 Missing ⚠️
ts/features/appReviews/store/reducers/index.ts 60.00% 6 Missing ⚠️
ts/screens/profile/DeveloperModeSection.tsx 0.00% 5 Missing ⚠️
ts/screens/profile/ProfileMainScreen.tsx 55.55% 4 Missing ⚠️
ts/store/reducers/backendStatus/remoteConfig.ts 66.66% 4 Missing ⚠️
...ts/checkout/screens/WalletPaymentOutcomeScreen.tsx 0.00% 2 Missing ⚠️
ts/features/appReviews/store/selectors/index.ts 90.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (86fdf44) and HEAD (3e2d0fe). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (86fdf44) HEAD (3e2d0fe)
10 7
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6617      +/-   ##
==========================================
- Coverage   50.94%   42.70%   -8.24%     
==========================================
  Files        1578     1568      -10     
  Lines       32717    32459     -258     
  Branches     7429     7346      -83     
==========================================
- Hits        16668    13862    -2806     
- Misses      15991    18545    +2554     
+ Partials       58       52       -6
Files with missing lines Coverage Δ
ts/features/appReviews/store/actions/index.ts 100.00% <100.00%> (ø)
ts/features/appReviews/utils/date.ts 100.00% <100.00%> (ø)
ts/features/appReviews/utils/storeReview.ts 100.00% <ø> (ø)
ts/features/common/store/reducers/index.ts 100.00% <ø> (ø)
...twallet/common/hooks/useItwPendingReviewRequest.ts 100.00% <100.00%> (ø)
...llet/wallet/components/ItwWalletCardsContainer.tsx 100.00% <100.00%> (ø)
ts/navigation/ProfileNavigator.tsx 66.66% <ø> (ø)
ts/navigation/routes.ts 100.00% <ø> (ø)
ts/features/appReviews/store/selectors/index.ts 90.00% <90.00%> (ø)
...ts/checkout/screens/WalletPaymentOutcomeScreen.tsx 0.72% <0.00%> (-84.68%) ⬇️
... and 6 more

... and 246 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86fdf44...3e2d0fe. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025 •
edited
Loading

PR Title Validation for conventional commit type

✅ All good! PR title follows the conventional commit type.

@CrisTofani CrisTofani changed the title [IOPLT-784] Request App feedback to user feat: [IOPLT-784] Request App feedback to user Feb 5, 2025
CrisTofani
CrisTofani commented Mar 6, 2025
View reviewed changes
Copy link
Contributor Author

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisMattew ChrisMattew Awaiting requested review from ChrisMattew ChrisMattew is a code owner

@gispada gispada Awaiting requested review from gispada gispada is a code owner

@freddi301 freddi301 Awaiting requested review from freddi301 freddi301 is a code owner

@shadowsheep1 shadowsheep1 Awaiting requested review from shadowsheep1

@Hantex9 Hantex9 Awaiting requested review from Hantex9

@LeleDallas LeleDallas Awaiting requested review from LeleDallas

@thisisjp thisisjp Awaiting requested review from thisisjp thisisjp is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
legal-review-needed ⚖️ ⛔ this PR is under legal check.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CrisTofani @mastro993 @thisisjp @shadowsheep1 @Hantex9 @LeleDallas