Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPLT-784] Request App feedback to user #6617

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Jan 20, 2025

Note

This PR depends on pagopa/io-services-metadata#928

Short description

This PR implements the new feature to let the user give a feedback on pre-defined survey during specific flows

List of changes proposed in this pull request

  • Handle the new remote config for app feedback
  • Implements the hook to handle the logic of alert presentation
  • Handle the store and persist of last given feedback log
  • Changes the previously implemented callback trigger to ask for review only on device app store

How to test

Check the specific playground under Settings > Developer mode > Playgrounds > App feedback playground
Use pagopa/io-dev-api-server#464 to test

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-05.at.16.36.44.mp4

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 56.73077% with 45 lines in your changes missing coverage. Please review.

Project coverage is 44.15%. Comparing base (f591e0a) to head (3870d56).

Files with missing lines Patch % Lines
.../features/appReviews/hooks/useAppReviewRequest.tsx 50.00% 14 Missing ⚠️
...eens/profile/playgrounds/AppFeedbackPlayground.tsx 9.09% 10 Missing ⚠️
ts/features/appReviews/store/reducers/index.ts 60.00% 6 Missing ⚠️
ts/screens/profile/DeveloperModeSection.tsx 0.00% 5 Missing ⚠️
ts/store/reducers/backendStatus/remoteConfig.ts 66.66% 4 Missing ⚠️
ts/screens/profile/ProfileMainScreen.tsx 62.50% 3 Missing ⚠️
...ts/checkout/screens/WalletPaymentOutcomeScreen.tsx 0.00% 2 Missing ⚠️
ts/features/appReviews/store/selectors/index.ts 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6617      +/-   ##
==========================================
- Coverage   46.40%   44.15%   -2.26%     
==========================================
  Files        1453     1576     +123     
  Lines       30546    32748    +2202     
  Branches     6913     7422     +509     
==========================================
+ Hits        14176    14459     +283     
- Misses      16320    18250    +1930     
+ Partials       50       39      -11     
Files with missing lines Coverage Δ
ts/features/appReviews/store/actions/index.ts 100.00% <100.00%> (ø)
ts/features/appReviews/utils/date.ts 100.00% <100.00%> (ø)
ts/features/appReviews/utils/storeReview.ts 100.00% <ø> (ø)
ts/features/common/store/reducers/index.ts 100.00% <ø> (+28.57%) ⬆️
...twallet/common/hooks/useItwPendingReviewRequest.ts 100.00% <100.00%> (ø)
...llet/wallet/components/ItwWalletCardsContainer.tsx 100.00% <100.00%> (ø)
ts/navigation/ProfileNavigator.tsx 66.66% <ø> (ø)
ts/navigation/routes.ts 100.00% <ø> (ø)
ts/features/appReviews/store/selectors/index.ts 90.00% <90.00%> (ø)
...ts/checkout/screens/WalletPaymentOutcomeScreen.tsx 0.72% <0.00%> (-84.68%) ⬇️
... and 6 more

... and 497 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f591e0a...3870d56. Read the comment docs.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@CrisTofani CrisTofani changed the title [IOPLT-784] Request App feedback to user feat: [IOPLT-784] Request App feedback to user Feb 5, 2025
@CrisTofani CrisTofani dismissed stale reviews from shadowsheep1, Hantex9, LeleDallas, and thisisjp March 5, 2025 15:47

Changed requirements during legal approval process

@CrisTofani
Copy link
Contributor Author

@shadowsheep1 @Hantex9 @LeleDallas @thisisjp I have to dismiss your review in order to ask you to check again the feature, since it has been changed from last checks due to further requirements 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legal-review-needed ⚖️ ⛔ this PR is under legal check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants