Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-357] Upgrade @gorhom/bottom-sheet library #6062

Open
wants to merge 71 commits into
base: master
Choose a base branch
from

Merge branch 'master' into IOAPPX-357-upgrade-bs-lib

baa1409
Select commit
Loading
Failed to load commit list.
Open

chore(Cross): [IOAPPX-357] Upgrade @gorhom/bottom-sheet library #6062

Merge branch 'master' into IOAPPX-357-upgrade-bs-lib
baa1409
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 6, 2025 in 0s

50.92% (-0.02%) compared to 5a91614

View this Pull Request on Codecov

50.92% (-0.02%) compared to 5a91614

Details

Codecov Report

Attention: Patch coverage is 39.77273% with 53 lines in your changes missing coverage. Please review.

Project coverage is 50.92%. Comparing base (5a91614) to head (baa1409).

Files with missing lines Patch % Lines
...ption/screens/UnsubscriptionConfirmationScreen.tsx 0.00% 6 Missing ⚠️
ts/utils/hooks/bottomSheet.tsx 50.00% 6 Missing ⚠️
...figuration/screens/InstrumentsEnrollmentScreen.tsx 0.00% 5 Missing ⚠️
...le/components/services/ManualConfigBottomSheet.tsx 0.00% 5 Missing ⚠️
ts/features/design-system/core/DSBottomSheet.tsx 0.00% 4 Missing ⚠️
.../features/pn/components/F24ListBottomSheetLink.tsx 40.00% 3 Missing ⚠️
...uration/screens/IbanConfigurationLandingScreen.tsx 0.00% 2 Missing ⚠️
...dpay/details/components/InitiativeRulesInfoBox.tsx 0.00% 2 Missing ⚠️
...pay/onboarding/screens/PDNDPrerequisitesScreen.tsx 0.00% 2 Missing ⚠️
...omponents/ItwPresentationCredentialStatusAlert.tsx 0.00% 2 Missing ⚠️
... and 14 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6062      +/-   ##
==========================================
- Coverage   50.94%   50.92%   -0.02%     
==========================================
  Files        1578     1578              
  Lines       32708    32680      -28     
  Branches     7374     7427      +53     
==========================================
- Hits        16663    16643      -20     
+ Misses      15998    15978      -20     
- Partials       47       59      +12
Files with missing lines Coverage Δ
...creens/PinCreation/usePinValidationBottomSheet.tsx 100.00% <100.00%> (ø)
...omponents/detail/eyca/EycaInformationComponent.tsx 66.66% <100.00%> (ø)
...eens/merchants/CgnMerchantCategoriesListScreen.tsx 53.84% <100.00%> (ø)
.../idpay/code/components/IdPayInfoCieBottomSheet.tsx 100.00% <100.00%> (ø)
...tails/hooks/useIdPayDiscountDetailsBottomSheet.tsx 52.63% <100.00%> (ø)
...timeline/components/TimelineDetailsBottomSheet.tsx 44.89% <100.00%> (ø)
...twallet/common/hooks/useItwFailureSupportModal.tsx 63.49% <100.00%> (ø)
...es/itwallet/common/hooks/useItwInfoBottomSheet.tsx 100.00% <100.00%> (ø)
...llet/wallet/components/ItwWalletCardsContainer.tsx 100.00% <100.00%> (ø)
...s/components/MessageDetail/RemoteContentBanner.tsx 70.00% <100.00%> (ø)
... and 32 more

... and 10 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a91614...baa1409. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov