-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IT Wallet): [SIW-951] Add user payment methods in new wallet section #5639
chore(IT Wallet): [SIW-951] Add user payment methods in new wallet section #5639
Conversation
…dd-wallet-generic-ui-components
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5639 +/- ##
==========================================
+ Coverage 48.15% 48.17% +0.02%
==========================================
Files 1461 1465 +4
Lines 30966 31001 +35
Branches 7512 7520 +8
==========================================
+ Hits 14912 14936 +24
- Misses 15986 15997 +11
Partials 68 68
Continue to review full report in Codecov by Sentry.
|
I tested it and it works as intended, but I also noticed
export const selectWalletCards = createSelector(selectWalletFeature, wallet =>
Object.values(wallet.cards)
) I'm not sure if the change is done in this PR, in case I'll add a comment about this 👍 |
@forrest57 Nice catch! Added this improvement in badec5b |
Warning
This PR depends on #5626 and pagopa/io-dev-api-server#358
Short description
This PR adds the user's payment methods in the new wallet section
List of changes proposed in this pull request
wallet
featureHow to test
With the
io-dev-api-server
, make sure to checkout this branch: pagopa/io-dev-api-server#358From the Profile section, enable the New wallet section FF.
You should be able to see payment cards in the wallet.
Preview