Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-525] Fix payment authorization webview on Android devices #5474

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

mastro993
Copy link
Contributor

Depends on pagopa/io-react-native-login-utils#11

Short description

This PR updates the library io-react-native-login-utils. This new version of the library allows Android users to navigate to other apps while authorizing payment, avoiding closing the webview as soon as the user brings the IO app to the background.

List of changes proposed in this pull request

  • Update io-react-native-login-utils depencency

How to test

Within Profile > Playgrounds > New Wallet > Payment, start a new payment flow. During the payment authorization, which is handler by a web view, try to navigate to other apps. Check that you can still finalize the payment.

Preview

Registrazione.schermo.2024-01-31.alle.15.58.48.mov

@mastro993 mastro993 changed the title [IOBP-504] Fix payment authorization webview on Android devices [IOBP-525] Fix payment authorization webview on Android devices Jan 31, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOBP-525] Fix payment authorization webview on Android devices chore: [IOBP-525] Fix payment authorization webview on Android devices Jan 31, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 31, 2024

Affected stories

  • ⚙️ IOBP-525: Aggiornamento versione libreria io-react-native-login-utils su app IO
    subtask of
    • ⚙️ IOBP-504: Analisi comportamento webview pagamento

Generated by 🚫 dangerJS against 4ccf6c2

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (20e54f4) 47.96% compared to head (4ccf6c2) 47.96%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5474   +/-   ##
=======================================
  Coverage   47.96%   47.96%           
=======================================
  Files        1406     1406           
  Lines       30438    30438           
  Branches     7443     7443           
=======================================
  Hits        14600    14600           
  Misses      15769    15769           
  Partials       69       69           
Files Coverage Δ
ts/utils/analytics.ts 43.07% <ø> (ø)
...s/screens/authentication/idpAuthSessionHandler.tsx 4.67% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e54f4...4ccf6c2. Read the comment docs.

@mastro993 mastro993 added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Jan 31, 2024
Copy link

dpulls bot commented Feb 9, 2024

🎉 All dependencies have been resolved !

@mastro993 mastro993 marked this pull request as ready for review February 9, 2024 08:53
@mastro993 mastro993 requested a review from a team as a code owner February 9, 2024 08:53
Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993 mastro993 merged commit d67f85f into master Feb 9, 2024
8 checks passed
@mastro993 mastro993 deleted the IOBP-504-fix-payment-authorization-web-view branch February 9, 2024 10:18
LazyAfternoons added a commit that referenced this pull request Feb 9, 2024
…-login-utils` (#5499)

## Short description
This PR updates the `Podfile.lock` after the
`io-react-native-login-utils` update of
[this](#5474) PR.

## How to test
Run `yarn` and `cd ios && bundler exec pod install && cd ..`. Finally,
run `git status` and ensure that there are no changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants