Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-241] Replace legacy FooterWithButtons in the DownloadProfileData screen #5472

Merged
merged 12 commits into from
Feb 13, 2024

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jan 31, 2024

Short description

This PR replaces the legacy FooterWithButtons in the DownloadProfileData screen

List of changes proposed in this pull request

  • Replace the legacy FooterWithButtons
  • Replace the legacy BaseScreenComponent with the new RNavScreenWithLargeHeader

Preview

Before After
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-01-31.at.15.35.42.mp4
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-01-31.at.15.33.30.mp4

How to test

Go to the ProfilePrivacy & PolicyAccess your data

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Jan 31, 2024
@dmnplb dmnplb requested a review from a team as a code owner January 31, 2024 14:39
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-241] Replace legacy FooterWithButtons in the DownloadProfileData screen chore: [IOAPPX-241] Replace legacy FooterWithButtons in the DownloadProfileData screen Jan 31, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 31, 2024

Affected stories

  • ⚙️ IOAPPX-241: Sostituzione di FooterWithButtons legacy in "Accedi ai tuoi dati"
    subtask of

Generated by 🚫 dangerJS against f78d99b

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (6cd3b34) 47.90% compared to head (ec459ae) 47.89%.
Report is 1 commits behind head on master.

❗ Current head ec459ae differs from pull request most recent head f78d99b. Consider uploading reports for the commit f78d99b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5472      +/-   ##
==========================================
- Coverage   47.90%   47.89%   -0.01%     
==========================================
  Files        1405     1405              
  Lines       30419    30419              
  Branches     7389     7389              
==========================================
- Hits        14571    14570       -1     
- Misses      15790    15791       +1     
  Partials       58       58              
Files Coverage Δ
ts/navigation/ProfileNavigator.tsx 22.22% <ø> (ø)
ts/screens/profile/DownloadProfileDataScreen.tsx 3.84% <0.00%> (-3.85%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ac530...f78d99b. Read the comment docs.

@pagopa-github-bot pagopa-github-bot changed the title chore: [IOAPPX-241] Replace legacy FooterWithButtons in the DownloadProfileData screen chore(Cross): [IOAPPX-241] Replace legacy FooterWithButtons in the DownloadProfileData screen Feb 1, 2024
@dmnplb dmnplb merged commit 027d442 into master Feb 13, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-241-replace-footer-buttons-access-data-screen branch February 13, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants