Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-242] Replace legacy FooterWithButtons in the 'Remove account' flow #5470

Merged
merged 11 commits into from
Feb 13, 2024

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jan 31, 2024

Short description

This PR replaces the legacy FooterWithButtons in the Remove account flow

List of changes proposed in this pull request

  • Replace the legacy FooterWithButtons with the new one in the following pages:
    • RemoveAccountInfoScreen
    • RemoveAccountDetailsScreen
    • RemoveAccountSuccessScreen
  • Replace BaseScreenComponent with the new RNavScreenWithLargeHeader in the RemoveAccountDetailsScreen
  • Fix RemoveAccountSuccessScreen empty state formatting with the new typographic styles

Preview

Before After
Simulator Screenshot - iPhone 14 Pro - 2024-01-31 at 14 28 16 Simulator Screenshot - iPhone 14 Pro - 2024-01-31 at 14 24 09

How to test

Go to the ProfilePrivacy & PolicyDelete your account

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Jan 31, 2024
@dmnplb dmnplb requested a review from a team as a code owner January 31, 2024 13:37
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-242] Replace legacy FooterWithButtons in the 'Remove account' flow chore: [IOAPPX-242] Replace legacy FooterWithButtons in the 'Remove account' flow Jan 31, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 31, 2024

Affected stories

  • ⚙️ IOAPPX-242: Sostituzione di FooterWithButtons legacy in "Elimina il tuo account"
    subtask of

Generated by 🚫 dangerJS against aa676a4

@pagopa-github-bot pagopa-github-bot changed the title chore: [IOAPPX-242] Replace legacy FooterWithButtons in the 'Remove account' flow chore(Cross): [IOAPPX-242] Replace legacy FooterWithButtons in the 'Remove account' flow Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (69c9be1) 47.90% compared to head (aa676a4) 47.90%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5470      +/-   ##
==========================================
- Coverage   47.90%   47.90%   -0.01%     
==========================================
  Files        1405     1405              
  Lines       30418    30419       +1     
  Branches     7388     7389       +1     
==========================================
- Hits        14572    14571       -1     
- Misses      15788    15790       +2     
  Partials       58       58              
Files Coverage Δ
ts/navigation/ProfileNavigator.tsx 22.22% <ø> (ø)
ts/screens/profile/RemoveAccountDetailsScreen.tsx 8.51% <0.00%> (ø)
ts/screens/profile/RemoveAccountInfoScreen.tsx 22.22% <0.00%> (+2.22%) ⬆️
ts/screens/profile/RemoveAccountSuccessScreen.tsx 20.00% <0.00%> (-17.50%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69c9be1...aa676a4. Read the comment docs.

@dmnplb dmnplb merged commit 6cd3b34 into master Feb 13, 2024
8 checks passed
@dmnplb dmnplb deleted the IOAPPX-242-replace-footer-buttons-remove-account branch February 13, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants