-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-242] Replace legacy FooterWithButtons
in the 'Remove account' flow
#5470
Merged
dmnplb
merged 11 commits into
master
from
IOAPPX-242-replace-footer-buttons-remove-account
Feb 13, 2024
Merged
chore(Cross): [IOAPPX-242] Replace legacy FooterWithButtons
in the 'Remove account' flow
#5470
dmnplb
merged 11 commits into
master
from
IOAPPX-242-replace-footer-buttons-remove-account
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FooterWithButtons
in the 'Remove account' flowFooterWithButtons
in the 'Remove account' flow
Affected stories
|
FooterWithButtons
in the 'Remove account' flowFooterWithButtons
in the 'Remove account' flow
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5470 +/- ##
==========================================
- Coverage 47.90% 47.90% -0.01%
==========================================
Files 1405 1405
Lines 30418 30419 +1
Branches 7388 7389 +1
==========================================
- Hits 14572 14571 -1
- Misses 15788 15790 +2
Partials 58 58
Continue to review full report in Codecov by Sentry.
|
CrisTofani
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR replaces the legacy
FooterWithButtons
in the Remove account flowList of changes proposed in this pull request
FooterWithButtons
with the new one in the following pages:RemoveAccountInfoScreen
RemoveAccountDetailsScreen
RemoveAccountSuccessScreen
BaseScreenComponent
with the newRNavScreenWithLargeHeader
in theRemoveAccountDetailsScreen
RemoveAccountSuccessScreen
empty state formatting with the new typographic stylesPreview
How to test
Go to the Profile → Privacy & Policy → Delete your account