Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-218] Add the new Titillium Sans Pro typeface to the codebase #5459

Merged
merged 7 commits into from
Feb 8, 2024

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jan 30, 2024

Short description

This PR adds the new Titillium Sans Pro (official repo) font files to the codebase to ensure compatibility with the new io-app-design-system updates.

List of changes proposed in this pull request

  • Add the new Titillium Sans Pro font files with relative license
  • Link the new font files to iOS and Android builds
  • Update io-app-design-system to 1.22.0

How to test

Run the app in the local environment. Try to change the font in some app components (e.g: TabNavigator) and check if everything is fine.

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Jan 30, 2024
@dmnplb dmnplb requested a review from a team as a code owner January 30, 2024 10:32
@pagopa-github-bot pagopa-github-bot changed the title [IACROSS-218] Add the new Titillium Sans Pro typeface to the codebase chore: [IACROSS-218] Add the new Titillium Sans Pro typeface to the codebase Jan 30, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 30, 2024

Affected stories

  • ⚙️ IOAPPX-218: Aggiunta del nuovo carattere Titilium Pro
    subtask of

Generated by 🚫 dangerJS against c3520ba

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2501d29) 47.96% compared to head (c3520ba) 47.96%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5459   +/-   ##
=======================================
  Coverage   47.96%   47.96%           
=======================================
  Files        1406     1406           
  Lines       30438    30438           
  Branches     7443     7443           
=======================================
  Hits        14600    14600           
  Misses      15769    15769           
  Partials       69       69           
Files Coverage Δ
ts/components/core/fonts.ts 95.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2501d29...c3520ba. Read the comment docs.

@dmnplb dmnplb changed the title chore: [IACROSS-218] Add the new Titillium Sans Pro typeface to the codebase chore: [IOAPPX-218] Add the new Titillium Sans Pro typeface to the codebase Jan 31, 2024
# Conflicts:
#	ios/ItaliaApp.xcodeproj/project.pbxproj
#	ios/ItaliaApp/Info.plist
#	package.json
#	yarn.lock
@pagopa-github-bot pagopa-github-bot changed the title chore: [IOAPPX-218] Add the new Titillium Sans Pro typeface to the codebase chore(Cross): [IOAPPX-218] Add the new Titillium Sans Pro typeface to the codebase Feb 8, 2024
Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on both Android and iOS device

@dmnplb dmnplb merged commit 20e54f4 into master Feb 8, 2024
8 checks passed
@dmnplb dmnplb deleted the IACROSS-218-add-titillium-sans-pro branch February 8, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants