-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-218] Add the new Titillium Sans Pro
typeface to the codebase
#5459
Conversation
Titillium Sans Pro
typeface to the codebaseTitillium Sans Pro
typeface to the codebase
Affected stories
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5459 +/- ##
=======================================
Coverage 47.96% 47.96%
=======================================
Files 1406 1406
Lines 30438 30438
Branches 7443 7443
=======================================
Hits 14600 14600
Misses 15769 15769
Partials 69 69
Continue to review full report in Codecov by Sentry.
|
Titillium Sans Pro
typeface to the codebaseTitillium Sans Pro
typeface to the codebase
# Conflicts: # ios/ItaliaApp.xcodeproj/project.pbxproj # ios/ItaliaApp/Info.plist # package.json # yarn.lock
Titillium Sans Pro
typeface to the codebaseTitillium Sans Pro
typeface to the codebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested on both Android and iOS device
Short description
This PR adds the new
Titillium Sans Pro
(official repo) font files to the codebase to ensure compatibility with the newio-app-design-system
updates.List of changes proposed in this pull request
Titillium Sans Pro
font files with relative licenseio-app-design-system
to1.22.0
How to test
Run the app in the local environment. Try to change the font in some app components (e.g:
TabNavigator
) and check if everything is fine.