-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-230] Remove datetimepicker
and react-native-modal-datetime-picker
dependencies
#5451
Conversation
datetimepicker
dependencydatetimepicker
dependency
Affected stories
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5451 +/- ##
=======================================
Coverage 47.90% 47.90%
=======================================
Files 1407 1407
Lines 30441 30441
Branches 7407 7407
=======================================
Hits 14583 14583
Misses 15800 15800
Partials 58 58 Continue to review full report in Codecov by Sentry.
|
🎉 All dependencies have been resolved ! |
datetimepicker
dependencydatetimepicker
dependency
datetimepicker
dependencydatetimepicker
and react-native-modal-datetime-picker
dependencies
@LazyAfternoons addressed in the commit ab49dbc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, since all PR dependencies have been solved.
Caution
This PR depends on #5476
Short description
This PR removes the
datetimepicker
andreact-native-modal-datetime-picker
dependencies, that were added during the development of the Sicilia Vola feature:List of changes proposed in this pull request
DateTimePicker
orphan componentpackage.json
How to test
Run the app on both iOS and Android