Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-230] Remove datetimepicker and react-native-modal-datetime-picker dependencies #5451

Merged
merged 18 commits into from
Feb 19, 2024

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jan 29, 2024

Caution

This PR depends on #5476

Short description

This PR removes the datetimepicker and react-native-modal-datetime-picker dependencies, that were added during the development of the Sicilia Vola feature:

List of changes proposed in this pull request

  • Remove DateTimePicker orphan component
  • Update package.json
  • Update Android related conf files

How to test

Run the app on both iOS and Android

@dmnplb dmnplb added the 💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed label Jan 29, 2024
@dmnplb dmnplb requested a review from a team as a code owner January 29, 2024 10:49
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-230] Remove datetimepicker dependency chore: [IOAPPX-230] Remove datetimepicker dependency Jan 29, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 29, 2024

Affected stories

  • ⚙️ IOAPPX-230: Rimozione del package datetimepicker non più utilizzato dopo la rimozione di sezioni legacy
    subtask of

Generated by 🚫 dangerJS against 938c5b9

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39a2611) 47.90% compared to head (938c5b9) 47.90%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5451   +/-   ##
=======================================
  Coverage   47.90%   47.90%           
=======================================
  Files        1407     1407           
  Lines       30441    30441           
  Branches     7407     7407           
=======================================
  Hits        14583    14583           
  Misses      15800    15800           
  Partials       58       58           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a2611...938c5b9. Read the comment docs.

@LazyAfternoons
Copy link
Contributor

This PR depends on #5476 because @react-native-community_datetimepicker is a direct dependency of react-native-modal-datetime-picker and the component DateTimePicker which wraps it should be removed in #5476.

Copy link

dpulls bot commented Feb 1, 2024

🎉 All dependencies have been resolved !

@pagopa-github-bot pagopa-github-bot changed the title chore: [IOAPPX-230] Remove datetimepicker dependency chore(Cross): [IOAPPX-230] Remove datetimepicker dependency Feb 1, 2024
@dmnplb dmnplb changed the title chore(Cross): [IOAPPX-230] Remove datetimepicker dependency chore(Cross): [IOAPPX-230] Remove datetimepicker and react-native-modal-datetime-picker dependencies Feb 1, 2024
@dmnplb
Copy link
Contributor Author

dmnplb commented Feb 1, 2024

@LazyAfternoons addressed in the commit ab49dbc

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since all PR dependencies have been solved.

@dmnplb dmnplb merged commit 76c841d into master Feb 19, 2024
8 checks passed
@dmnplb dmnplb deleted the IOAPPX-230-remove-datetimepicker branch February 19, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross 💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants