Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOBP-487] Transaction_operation_details swipe back handling #5449

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

forrest57
Copy link
Contributor

Short description

Fixed a bug that would make the app not handle the swipe back correctly in WALLET_TRANSACTION_OPERATION_DETAILS

List of changes proposed in this pull request

  • fixed gesture handling in navigator

How to test

In the app, activate the beta design system option under the profile section, then:

  • navigate to the wallet section
  • scroll down to the transaction list ("load more" in case none is rendered)
  • open up a transaction's details
  • click the blue cta right under the title
  • after the navigation, make sure that both the swipe back in iOS and the top back button press correctly navigate to WALLET_TRANSACTION_DETAILS

@forrest57 forrest57 requested a review from a team as a code owner January 29, 2024 09:37
@pagopa-github-bot pagopa-github-bot changed the title [IOBP-487] transaction_operation_details swipe back handling fix: [IOBP-487] Transaction_operation_details swipe back handling Jan 29, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 29, 2024

Affected stories

  • 🐞 IOBP-487: Swipe back rimanda a pagina errata

Generated by 🚫 dangerJS against d050130

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5480d7) 47.31% compared to head (d050130) 47.31%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5449   +/-   ##
=======================================
  Coverage   47.31%   47.31%           
=======================================
  Files        1463     1463           
  Lines       31374    31374           
  Branches     7630     7630           
=======================================
  Hits        14846    14846           
  Misses      16470    16470           
  Partials       58       58           
Files Coverage Δ
...ures/walletV3/transaction/navigation/navigator.tsx 75.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5480d7...d050130. Read the comment docs.

Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forrest57 forrest57 merged commit 340ff73 into master Jan 31, 2024
8 checks passed
@forrest57 forrest57 deleted the IOBP-487-swipe-back-rimanda-a-pagina-errata branch January 31, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants