Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPID-1395] Update FeatureInfo font size #5445

Conversation

Ladirico
Copy link
Contributor

@Ladirico Ladirico commented Jan 26, 2024

Short description

I've update the version of io-app-design-system library with the font adaptation, i've change some text and i've change the rules to show/not show the icon into the opt-in screen and change some texts

iPhone 13 mini iPhone 13
Registrazione.schermo.2024-01-31.alle.15.02.40.mov
Registrazione.schermo.2024-01-31.alle.15.06.49.mov

How to test

Run the application and pay attention to opt-in and error 1002 screens, as you can see from the screen recording.

@Ladirico Ladirico added the IO-A&I IO - Autenticazione e Identità label Jan 26, 2024
@Ladirico Ladirico requested a review from shadowsheep1 January 26, 2024 08:24
@Ladirico Ladirico self-assigned this Jan 26, 2024
@Ladirico Ladirico requested review from thisisjp and a team as code owners January 26, 2024 08:24
@pagopa-github-bot pagopa-github-bot changed the title [IOPID-1395] update FeatureInfo font size chore: [IOPID-1395] Update FeatureInfo font size Jan 26, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 26, 2024

Affected stories

  • ⚙️ IOPID-1395: [APP] Aggiornare la dimensione dei testi nel componente FeatureInfo
    subtask of
    • IOPID-541: Login Veloce - evolutive mandatory (post go-live)

Generated by 🚫 dangerJS against 928ea95

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d196ef6) 48.16% compared to head (928ea95) 48.16%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5445   +/-   ##
=======================================
  Coverage   48.16%   48.16%           
=======================================
  Files        1420     1420           
  Lines       30572    30573    +1     
  Branches     7506     7452   -54     
=======================================
+ Hits        14726    14727    +1     
- Misses      15778    15788   +10     
+ Partials       68       58   -10     
Files Coverage Δ
ts/screens/authentication/NewOptInScreen.tsx 82.14% <100.00%> (+0.66%) ⬆️
ts/screens/onboarding/UnlockAccessScreen.tsx 76.92% <ø> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d196ef6...928ea95. Read the comment docs.

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ladirico Ladirico merged commit 8c13379 into master Jan 31, 2024
8 checks passed
@Ladirico Ladirico deleted the IOPID-1395-app-aggiornare-la-dimensione-dei-testi-nel-componente-feature-info branch January 31, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants