-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOAPPX-219] Remove unused types dependencies #5436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected stories
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5436 +/- ##
=======================================
Coverage 47.31% 47.31%
=======================================
Files 1463 1463
Lines 31374 31374
Branches 7630 7630
=======================================
Hits 14846 14846
Misses 16470 16470
Partials 58 58 Continue to review full report in Codecov by Sentry.
|
CrisTofani
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR removes two unused types dependencies found by running
npx depcheck
.List of changes proposed in this pull request
@types/stacktrace-js
due to the removal of stacktrace-js in this PR;@types/react-native-loading-spinner-overlay
due to the removal ofreact-native-spinner-overlay
in this PR.How to test
Static checks should be enough but also test if the app bootstraps properly by clearing Metro's transform cache with
yarn && yarn start -- --reset-cache
.