Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOAPPX-219] Remove unused types dependencies #5436

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

LazyAfternoons
Copy link
Contributor

@LazyAfternoons LazyAfternoons commented Jan 24, 2024

Short description

This PR removes two unused types dependencies found by running npx depcheck.

List of changes proposed in this pull request

  • Removes @types/stacktrace-js due to the removal of stacktrace-js in this PR;
  • Removes @types/react-native-loading-spinner-overlay due to the removal of react-native-spinner-overlay in this PR.

How to test

Static checks should be enough but also test if the app bootstraps properly by clearing Metro's transform cache with yarn && yarn start -- --reset-cache.

@pagopa-github-bot pagopa-github-bot changed the title [IACROSS-219] Remove unused types dependencies chore: [IACROSS-219] Remove unused types dependencies Jan 24, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 24, 2024

Affected stories

  • ⚙️ IOAPPX-219: Rimozione dipendenze types non più utilizzate
    subtask of

Generated by 🚫 dangerJS against 08e2283

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d8c358) 47.31% compared to head (08e2283) 47.31%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5436   +/-   ##
=======================================
  Coverage   47.31%   47.31%           
=======================================
  Files        1463     1463           
  Lines       31374    31374           
  Branches     7630     7630           
=======================================
  Hits        14846    14846           
  Misses      16470    16470           
  Partials       58       58           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d8c358...08e2283. Read the comment docs.

@LazyAfternoons LazyAfternoons marked this pull request as ready for review January 24, 2024 18:22
@LazyAfternoons LazyAfternoons requested a review from a team as a code owner January 24, 2024 18:22
@LazyAfternoons LazyAfternoons added the 💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed label Jan 26, 2024
@LazyAfternoons LazyAfternoons changed the title chore: [IACROSS-219] Remove unused types dependencies chore: [IOAPPX-219] Remove unused types dependencies Jan 27, 2024
@LazyAfternoons LazyAfternoons merged commit f029a3b into master Jan 30, 2024
8 checks passed
@LazyAfternoons LazyAfternoons deleted the IACROSS-219-remove-type-deps branch January 30, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants