Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-517] Removes unnecessary gallery permission on iOS #5433

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Jan 24, 2024

Short description

This PR removes an unnecessary gallery permission request on iOS.

List of changes proposed in this pull request

  • Removed iOS case in requestMediaPermission function

How to test

From the QR Code scan screen, choose the upload photo option and check that on iOS no prompt is displayed.

Previews

RocketSim_Recording_iPhone_14_6.1_2024-01-24_14.03.35.mp4

@mastro993 mastro993 requested a review from a team as a code owner January 24, 2024 13:14
@pagopa-github-bot pagopa-github-bot changed the title [IOBP-517] Remove gallery permission request if iOS >= 17 chore: [IOBP-517] Remove gallery permission request if iOS >= 17 Jan 24, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 24, 2024

Affected stories

  • ⚙️ IOBP-517: Rimuovere prompt permessi galleria su iOS 17 durante scansione QR Code

Generated by 🚫 dangerJS against 06d6945

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (68cae1f) 47.45% compared to head (761919d) 47.44%.

❗ Current head 761919d differs from pull request most recent head 06d6945. Consider uploading reports for the commit 06d6945 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5433      +/-   ##
==========================================
- Coverage   47.45%   47.44%   -0.01%     
==========================================
  Files        1603     1603              
  Lines       33620    33621       +1     
  Branches     8212     8215       +3     
==========================================
  Hits        15953    15953              
- Misses      17609    17610       +1     
  Partials       58       58              
Files Coverage Δ
ts/utils/permission.ts 18.51% <0.00%> (-0.72%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68cae1f...06d6945. Read the comment docs.

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mastro993 mastro993 changed the title chore: [IOBP-517] Remove gallery permission request if iOS >= 17 chore: [IOBP-517] Removes unnecessary gallery permission on iOS Jan 24, 2024
@mastro993 mastro993 merged commit 229906d into master Jan 24, 2024
6 checks passed
@mastro993 mastro993 deleted the IOBP-517-rimuovere-prompt-permessi-galleria-su-i-os-17-durante-scansione-qr-code branch January 24, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants