Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOBP-512] Wallet details with new generic error screen #5427

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Jan 23, 2024

Short description

This PR implements the new generic error screen using the OperationResultScreenContent component.

List of changes proposed in this pull request

  • Removed from WalletDetailsScreen the old and deprecated WorkunitGenericFailure with the new one

How to test

Start and complete an onboarding flow with a new card and when you are in the method details screen, try to force an error on that page.

Preview

Before After

@Hantex9 Hantex9 added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Jan 23, 2024
@Hantex9 Hantex9 requested review from thisisjp and a team as code owners January 23, 2024 16:10
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 23, 2024

Affected stories

  • 🐞 IOBP-512: Aggiornare schermata di errore nel nuovo dettaglio wallet

Generated by 🚫 dangerJS against b241ab9

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (71d6507) 47.46% compared to head (b241ab9) 47.45%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5427      +/-   ##
==========================================
- Coverage   47.46%   47.45%   -0.01%     
==========================================
  Files        1604     1604              
  Lines       33600    33606       +6     
  Branches     8204     8204              
==========================================
  Hits        15948    15948              
- Misses      17594    17600       +6     
  Partials       58       58              
Files Coverage Δ
...s/walletV3/details/screens/WalletDetailsScreen.tsx 7.89% <0.00%> (-1.49%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d6507...b241ab9. Read the comment docs.

Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hantex9 Hantex9 merged commit 893d6e4 into master Jan 24, 2024
8 checks passed
@Hantex9 Hantex9 deleted the IOBP-512-fix-error-screen-into-wallet-details branch January 24, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants