feat(Firma con IO): [SFEQS-2083] Replace abort bottom sheet with alert #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5425 +/- ##
=======================================
Coverage 47.82% 47.83%
=======================================
Files 1418 1418
Lines 30704 30710 +6
Branches 7467 7467
=======================================
+ Hits 14685 14689 +4
- Misses 15960 15962 +2
Partials 59 59
Continue to review full report in Codecov by Sentry.
|
hevelius
requested changes
Jan 23, 2024
LazyAfternoons
force-pushed
the
SFEQS-2083-replace-dialog
branch
from
e81edac to
2fc1faf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR replaces the abort bottom sheet with an alert when using the new design system, according to this FIGMA.
The shown alert is just a placeholder for a nativa alert, thus we are leaving Apple and OEMs for Android to decide how it looks on each device, including the order of the buttons.
On iOS the
style: 'cancel'prop places the button as second when text requires wrapping. On Android, two buttons meansnegative,positiveand are placed accordingly (ref).List of changes proposed in this pull request
presentfunction of the bottom sheet to show an alert instead if the experimental design is enabled.This allows us to use an alert without changing single components which use the hook.
The bottom sheet will be removed once the experimental design is enabled by default (SFEQS-2090).
How to test
Open a signature flow either in production or with
io-dev-api-serverby setting the flagwaitForSignatureCount: 1. Then try to abort it. Either a bottom sheet or an alert should be displayed if the experimental design system is disabled or not.