Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOBP-518, IOBP-519] Handle payment dismissal after authorization request #5423

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Jan 23, 2024

Depends on #5419

Short description

This PR add the handling of payment dismissal after payment authorization request

List of changes proposed in this pull request

  • Added onDismiss in useWalletPaymentAuthorizationModal hook
  • Added outcome screen navigation on authorization dismissal

How to test

Start a new payment flow from Profile > Playgrounds > New Wallet > Payment, dismiss the authorization webview in the last step and check that the payment is correctly cancelled.

Previews

RocketSim_Recording_iPhone_13_6.1_2024-01-23_10.00.17.mp4

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 23, 2024

Warnings
⚠️ Please include a Pivotal story or Jira ticket at the beginning of the PR title

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Example of PR titles that include Jira tickets:

  • single story: [PROJID-123] my PR title
  • multiple stories: [PROJID-1,PROJID-2,PROJID-3] my PR title

Generated by 🚫 dangerJS against a3408ab

@mastro993 mastro993 added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (71ca2a2) 47.45% compared to head (a3408ab) 47.42%.
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5423      +/-   ##
==========================================
- Coverage   47.45%   47.42%   -0.03%     
==========================================
  Files        1603     1603              
  Lines       33618    33641      +23     
  Branches     8211     8219       +8     
==========================================
+ Hits        15953    15955       +2     
- Misses      17607    17628      +21     
  Partials       58       58              
Files Coverage Δ
...aga/networking/handleWalletPaymentCalculateFees.ts 88.88% <100.00%> (ø)
...networking/handleWalletPaymentCreateTransaction.ts 85.71% <100.00%> (+1.09%) ⬆️
...tures/walletV3/payment/store/actions/networking.ts 100.00% <ø> (ø)
...yment/hooks/useWalletPaymentAuthorizationModal.tsx 2.94% <0.00%> (-0.09%) ⬇️
...features/walletV3/payment/store/selectors/index.ts 41.66% <25.00%> (-2.09%) ⬇️
...tV3/payment/screens/WalletPaymentConfirmScreen.tsx 10.00% <0.00%> (+0.90%) ⬆️
...tV3/payment/screens/WalletPaymentPickPspScreen.tsx 3.22% <0.00%> (-0.42%) ⬇️
.../payment/screens/WalletPaymentPickMethodScreen.tsx 8.04% <0.00%> (-1.42%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295b838...a3408ab. Read the comment docs.

Copy link

dpulls bot commented Jan 25, 2024

🎉 All dependencies have been resolved !

@forrest57
Copy link
Contributor

LGTM (after resolving the merge conflict, of course 😓 )

@mastro993 mastro993 merged commit e374369 into master Jan 25, 2024
8 checks passed
@mastro993 mastro993 deleted the IOBP-518-annullare-flusso-di-pagamento-se-viene-chiusa-web-view-di-autorizzazione branch January 25, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants