chore: [IOBP-488] Refactor bonus features to remove cross feature dependencies #5397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
mastro993
added
IO-Bonus e pagamenti
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5397 +/- ##
=======================================
Coverage 47.30% 47.30%
=======================================
Files 1641 1645 +4
Lines 34330 34330
Branches 8388 8388
=======================================
Hits 16241 16241
Misses 18031 18031
Partials 58 58
Continue to review full report in Codecov by Sentry.
|
CrisTofani
reviewed
Jan 12, 2024
ts/components/FooterTopShadow.tsx
Outdated
| import variables from "../../../../theme/variables"; | ||
| import { StyleSheet, View } from "react-native"; | ||
| import variables from "../theme/variables"; | ||
| import { IOStyles } from "./core/variables/IOStyles"; |
There was a problem hiding this comment.
Can we use the one exported from @pagopa/io-app-design-system instead?
There was a problem hiding this comment.
Sure! See 76dab28
forrest57
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
tested on both IOS and Android, with full CGN flow and all seems well, I say LGTM!
after the changes suggested by @CrisTofani, sorry 😓
mastro993
force-pushed
the
IOBP-488-remove-cross-dependency-for-bonus-features
branch
from
ae5d337 to
76dab28
Compare
hevelius
approved these changes
Jan 15, 2024
mastro993
deleted the
IOBP-488-remove-cross-dependency-for-bonus-features
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR is preparatory to the removal of the legacy code associated with SiciliaVola, Cashback and Bonus Vacanze features.
It consists of a major refactoring of the
bonusfeature, removing cross dependency between features, and a relocation of some of the components used in the IO app.List of changes proposed in this pull request
bonusReducer, moved it outsidebonusVacanzefeature folderfeatures/bonus/bonusVacanze/models/RemoteValuetocommon/models/RemoteValuefeatures/bonus/bonusVacanze/components/buttons/*components tocomponents/buttons/*features/bonus/bonusVacanze/components/loadingScreenComponent/LoadingErrorComponenttocomponents/LoadingErrorComponentfeatures/bonus/bonusVacanze/components/markdown/*tocomponents/markdown/*features/bonus/bonusVacanze/components/FooterTopShadowtocomponents/FooterTopShadowHow to test
All tests should solve correctly, app should build correctly on all platforms