-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOBP-309, IOBP-312] Add error handling for payment verification and activation requests #5378
feat: [IOBP-309, IOBP-312] Add error handling for payment verification and activation requests #5378
Conversation
…ca-avviso-integrazione-ecommerce
Example of PR titles that include pivotal stories:
Example of PR titles that include Jira tickets:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5378 +/- ##
==========================================
- Coverage 47.48% 47.38% -0.11%
==========================================
Files 1636 1639 +3
Lines 34146 34231 +85
Branches 8346 8364 +18
==========================================
+ Hits 16213 16219 +6
- Misses 17875 17954 +79
Partials 58 58
Continue to review full report in Codecov by Sentry.
|
…ca-avviso-integrazione-ecommerce
…ca-avviso-integrazione-ecommerce
…ca-avviso-integrazione-ecommerce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ts/features/walletV3/payment/hooks/usePaymentFailureSupportModal.tsx
Outdated
Show resolved
Hide resolved
ts/features/walletV3/payment/hooks/usePaymentFailureSupportModal.tsx
Outdated
Show resolved
Hide resolved
…ca-avviso-integrazione-ecommerce
Fixed in 141c5f7 |
…ca-avviso-integrazione-ecommerce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ca-avviso-integrazione-ecommerce
⚠️ Depends on #5378 ## Short description This PR adds the handling of the payment error outcomes. ## List of changes proposed in this pull request - Added components mapping based on the outcome in `WalletPaymentOutcomeScreen` - Added required locales keys - Refactored `usePaymentFailureSupportModal` to remove the requirement of passing `RptId` as its argument. ## How to test Within the **Profile > New Wallet > Payment** playground, using the `io-dev-api-server`, try to simulate different payment outcomes and check that the screen and its components are displayed correctly. ## Preview https://github.com/pagopa/io-app/assets/6160324/cb7c33f1-9c0d-471c-accf-a362efc42264 --------- Co-authored-by: Alessandro Izzo <[email protected]> Co-authored-by: Mario Perrotta <[email protected]>
Short description
This PR adds the handling of failures during the verification and activation requests for a payment.
List of changes proposed in this pull request
WalletPaymentFailure
typeWalletPaymentFailureDetail
component to display payment failuresusePaymentFailureSupportModal
hook to display the payment support request bottom sheet modalHow to test
Using the io-dev-api-server, checkout this branch pagopa/io-dev-api-server#335 and add the following to the config.json:
With the IO app, navigate to the wallet payment playground and check that the failure is correctly displayed.
Preview
RocketSim_Recording_iPhone_13_6.1_2024-01-04_17.12.43.mp4