Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-2036] Prevent user interactions with components requiring internet access #6782

Draft
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Mar 4, 2025

Warning

Depends on #6778

Short description

Include a summary of the changes.

List of changes proposed in this pull request

  • Feature A
  • Feature B

How to test

Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Ladirico and others added 29 commits February 27, 2025 16:50
…sses the app and is redirected to the offline wallet
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 46.47887% with 38 lines in your changes missing coverage. Please review.

Project coverage is 50.98%. Comparing base (f66da68) to head (58695b2).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
.../screens/ItwPresentationCredentialDetailScreen.tsx 0.00% 7 Missing ⚠️
ts/navigation/AppStackNavigator.tsx 0.00% 7 Missing ⚠️
...eatures/connectivity/screen/NoConnectionScreen.tsx 25.00% 6 Missing ⚠️
...eatures/itwallet/wallet/utils/withOfflineAlert.tsx 0.00% 5 Missing ⚠️
ts/features/ingress/store/reducer/index.ts 0.00% 4 Missing ⚠️
ts/features/ingress/screens/IngressScreen.tsx 86.66% 2 Missing ⚠️
ts/features/itwallet/common/saga/index.ts 0.00% 2 Missing ⚠️
...features/itwallet/navigation/ItwStackNavigator.tsx 0.00% 2 Missing ⚠️
ts/features/ingress/store/selectors/index.ts 50.00% 1 Missing ⚠️
ts/navigation/OfflineStackNavigator.tsx 66.66% 1 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6782      +/-   ##
==========================================
- Coverage   50.99%   50.98%   -0.01%     
==========================================
  Files        1579     1582       +3     
  Lines       32706    32735      +29     
  Branches     7361     7422      +61     
==========================================
+ Hits        16679    16691      +12     
- Misses      15982    15985       +3     
- Partials       45       59      +14     
Files with missing lines Coverage Δ
...eatures/connectivity/hooks/useConnectivityGuard.ts 100.00% <100.00%> (ø)
ts/features/ingress/store/actions/index.ts 100.00% <100.00%> (ø)
...es/itwallet/common/store/selectors/remoteConfig.ts 71.05% <ø> (ø)
...et/trustmark/components/ItwCredentialTrustmark.tsx 24.07% <ø> (+3.10%) ⬆️
ts/features/wallet/store/selectors/index.ts 93.75% <100.00%> (+4.16%) ⬆️
ts/navigation/AuthenticatedStackNavigator.tsx 17.64% <ø> (ø)
ts/navigation/params/AppParamsList.ts 100.00% <ø> (ø)
ts/navigation/routes.ts 100.00% <ø> (ø)
ts/screens/modal/IdentificationModal.tsx 39.24% <100.00%> (ø)
ts/store/reducers/startup.ts 73.91% <ø> (ø)
... and 11 more

... and 23 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9f6a9b...58695b2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants