Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-2072] Ensure ITW is ready when app enters offline mode #6778

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Mar 4, 2025

Warning

Depends on #6767

Short description

This PR ensures that all ITW data is available when app enters offline mode.

Demo

Registrazione.schermo.2025-03-05.alle.11.22.27.mov

List of changes proposed in this pull request

  • Moved handleWalletCredentialsRehydration before any network call inside the initializeApplicationSaga
  • shouldRenderItwCardsContainerSelector now returns true if the remote FF is turned off but the app is offline
  • withItwEnabled HOC now renders the screen if the remote FF is turned off but the app is offline
  • Updated tests

How to test

Go to Settings → Documenti su IO → Enable offline access .
With the app online → check if there aren't regressions
With the app offline → with a valid Wallet Instance, check if you are able to see your wallet with all the credentials.

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Mar 4, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@mastro993 mastro993 marked this pull request as ready for review March 5, 2025 08:20
Copy link
Contributor

@ale-mazz ale-mazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iPhone 13 mini. When offline the bundler was not connected but everything looks ok, I still have my MDL. Tried a reload with connection and everything was working normally. Will test also #6782 when ready!
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants