-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOBP-1186,IOBP-1187] Add a11y announcement when sorting the PSP list #6775
base: master
Are you sure you want to change the base?
Conversation
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6775 +/- ##
==========================================
+ Coverage 46.40% 50.98% +4.57%
==========================================
Files 1453 1578 +125
Lines 30546 32691 +2145
Branches 6913 7407 +494
==========================================
+ Hits 14176 16666 +2490
+ Misses 16320 15979 -341
+ Partials 50 46 -4
... and 324 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Short description
This PR adds the a11y feature announcement when sorting the PSP list and added a more detailed accessibility label on the radio items showing the order type.
List of changes proposed in this pull request
io-app-design-system
with theaccessibilityLabel
prop to theRadioItem
(v5.0.5
)present
wrapper function inside theuseSortPspBottomSheet
that announces the a11y description;accessibilityLabel
on every radio item;WalletPaymentMakeScreen
setting the flex prop to the View encapsulated inside thePagerView
How to test
yarn install
;Sort
CTA and check that the description is announced correctly;