-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOPID-2798] Add new copy on logout alert if there is an active wallet instance #6772
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6772 +/- ##
==========================================
- Coverage 50.98% 44.00% -6.98%
==========================================
Files 1577 1444 -133
Lines 32675 30380 -2295
Branches 7351 6811 -540
==========================================
- Hits 16659 13370 -3289
- Misses 15971 16974 +1003
+ Partials 45 36 -9
... and 372 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Short description
In this PR, a new copy was added in the alert that is shown in the logout screen to be shown to users who have the wallet instance active
Demo
wi_active_alert_logout.mov
not_wi_alert_logout_asis.mov
How to test
itwLifecycleIsOperationalOrValid
:true
if you need an active wallet instance.false
if you want to test the flow without a wallet instance.