Skip to content

Commit

Permalink
chore(Cross): [IOAPPX-439] Enable the iridescent trust mark for all (#…
Browse files Browse the repository at this point in the history
…6444)

## Short description
This PR enables the iridescent trust mark for all. It was previosuly
tested internally through the experimental DS feature flag.
To learn more about the effect:
* #6179

## List of changes proposed in this pull request
- Update `react-native-skia` to the latest version to take advantage of
Android performance improvements

## How to test
Go to the credential detail page with experimental DS disabled and check
if everything is OK
  • Loading branch information
dmnplb authored Nov 26, 2024
1 parent 8f5e18e commit aa744cd
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 15 deletions.
4 changes: 2 additions & 2 deletions ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ PODS:
- React-Core
- react-native-screen-brightness (2.0.0-alpha):
- React
- react-native-skia (1.3.13):
- react-native-skia (1.5.10):
- RCT-Folly (= 2021.07.22.00)
- React
- React-callinvoker
Expand Down Expand Up @@ -1098,7 +1098,7 @@ SPEC CHECKSUMS:
react-native-render-html: 96c979fe7452a0a41559685d2f83b12b93edac8c
react-native-safe-area-context: 399a5859f6acbdf67f671c69b53113f535f3b5b0
react-native-screen-brightness: 9eefe6db96a5d757e63cdfce8e48d7c9039f2af2
react-native-skia: c0d99aa1fb10f6d97627c1dc018c0ab269439a76
react-native-skia: 7bfe9c816d6ce75bcda1101ca0d53e221e5598f9
react-native-slider: e99fc201cefe81270fc9d81714a7a0f5e566b168
react-native-splash-screen: 200d11d188e2e78cea3ad319964f6142b6384865
react-native-view-shot: 4475fde003fe8a210053d1f98fb9e06c1d834e1c
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
"@redux-saga/testing-utils": "^1.1.3",
"@sentry/react-native": "^5.32.0",
"@shopify/flash-list": "~1.7.0",
"@shopify/react-native-skia": "^1.3.13",
"@shopify/react-native-skia": "^1.5.10",
"@textlint/markdown-to-ast": "^14.0.4",
"@xstate/react": "^4.0.1",
"async-mutex": "^0.1.3",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
/* eslint-disable functional/immutable-data */
import {
Caption,
hexToRgba,
useIOExperimentalDesign,
WithTestID
} from "@pagopa/io-app-design-system";
import { Caption, hexToRgba, WithTestID } from "@pagopa/io-app-design-system";
import {
Canvas,
ImageSVG,
Expand Down Expand Up @@ -91,8 +86,9 @@ export const ItwCredentialTrustmark = ({
itwCredentialStatusSelector(state, credential.credentialType)
);

/* Enable the effect only when the experimental DS is enabled */
const { isExperimental: enableIridescence } = useIOExperimentalDesign();
/* If you want to restore the static variant of the trustmark,
please set the following variable to false */
const enableIridescence = true;

const rotationSensor = useAnimatedSensor(SensorType.ROTATION);
const currentRoll = useSharedValue(0);
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2956,10 +2956,10 @@
recyclerlistview "4.2.1"
tslib "2.6.3"

"@shopify/react-native-skia@^1.3.13":
version "1.3.13"
resolved "https://registry.yarnpkg.com/@shopify/react-native-skia/-/react-native-skia-1.3.13.tgz#8f3773db280ebe0adf57d24ae5f804400c4524c3"
integrity sha512-7LvSy+4nvJRGSDJi1fHVtbMxSDRnV2csTGB8RCcdFJsqQHxuIF05jM1GkrEbp/qCZHVPKKrjxbtHByERvx7OPQ==
"@shopify/react-native-skia@^1.5.10":
version "1.5.10"
resolved "https://registry.yarnpkg.com/@shopify/react-native-skia/-/react-native-skia-1.5.10.tgz#175ce6441186fe2ed6bd4f4535b1d93287426842"
integrity sha512-wjWE0eY6PJiWw1fIjh/XgpLGivnTNwASCDZCecpUMMNB3df2SaZUOSO1k1jBFzQ/2GXbf95CSd8DAA9caSl5nA==
dependencies:
canvaskit-wasm "0.39.1"
react-reconciler "0.27.0"
Expand Down

0 comments on commit aa744cd

Please sign in to comment.