Skip to content

Commit

Permalink
chore: [IOBP-1013] New copy for card method removal (#6419)
Browse files Browse the repository at this point in the history
## Short description
This pull request includes changes to the localization files for card
removal button and toast.

## List of changes proposed in this pull request
- Update localization
- Add missing toast on backend failure

## How to test
- Try to remove a payment method
- Check toast message text
  • Loading branch information
LeleDallas authored Nov 19, 2024
1 parent 5002895 commit 795040d
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 15 deletions.
4 changes: 2 additions & 2 deletions locales/de/index.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1381,7 +1381,7 @@ wallet:
android:
confirm: "Entfernen"
successful: "Zahlungsmethode von deinem Konto entfernt!"
failed: "Die Zahlungsmethode kann nicht von deinem Konto entfernt werden"
failed: "Es gab ein Problem, bitte versuche es erneut"
newPaymentMethod:
add: "Hinzufügen"
show: "Anzeigen"
Expand Down Expand Up @@ -1889,7 +1889,7 @@ cardComponent:
lastUsage: "Letzte Verwendung"
detailsAndTransactions: "Details und Transaktionen"
pick: "Diese Zahlungsmethode verwenden"
removeCta: "Diese Zahlungsmethode entfernen"
removeCta: "Aus Wallet entfernen"
messages:
accessibility:
message:
Expand Down
4 changes: 2 additions & 2 deletions locales/en/index.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1458,7 +1458,7 @@ wallet:
android:
confirm: Delete
successful: Method removed!
failed: The method could not be removed from your Wallet
failed: There was a problem, please try again
newPaymentMethod:
add: add
show: show
Expand Down Expand Up @@ -2011,7 +2011,7 @@ cardComponent:
lastUsage: Last usage
detailsAndTransactions: Details and transactions
pick: Pay with this method
removeCta: "Delete this payment method"
removeCta: "Remove from Wallet"
messages:
accessibility:
message:
Expand Down
4 changes: 2 additions & 2 deletions locales/it/index.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1459,7 +1459,7 @@ wallet:
android:
confirm: Rimuovi
successful: Metodo rimosso!
failed: Impossibile rimuovere il metodo dal tuo Portafoglio
failed: C’è stato un problema, riprova
newPaymentMethod:
add: aggiungi
show: mostra
Expand Down Expand Up @@ -2012,7 +2012,7 @@ cardComponent:
lastUsage: Ultimo utilizzo
detailsAndTransactions: Dettagli e transazioni
pick: Paga con questo metodo
removeCta: "Elimina questo metodo"
removeCta: "Rimuovi dal Portafoglio"
messages:
accessibility:
message:
Expand Down
13 changes: 4 additions & 9 deletions ts/features/payments/details/saga/handleDeleteWalletDetails.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ export function* handleDeleteWalletDetails(
action.payload.walletId
);
yield* put(successAction);
if (action.payload.onSuccess) {
action.payload.onSuccess();
}
action.payload.onSuccess?.();
return;
}
if (deleteWalletResult.right.status !== 401) {
Expand All @@ -55,9 +53,7 @@ export function* handleDeleteWalletDetails(
)
});
yield* put(failureAction);
if (action.payload.onFailure) {
action.payload.onFailure();
}
action.payload.onFailure?.();
}
} else {
// cannot decode response
Expand All @@ -67,13 +63,12 @@ export function* handleDeleteWalletDetails(
)
});
yield* put(failureAction);
if (action.payload.onFailure) {
action.payload.onFailure();
}
action.payload.onFailure?.();
}
} catch (e) {
yield* put(
paymentsGetMethodDetailsAction.failure({ ...getNetworkError(e) })
);
action.payload.onFailure?.();
}
}

0 comments on commit 795040d

Please sign in to comment.