-
Notifications
You must be signed in to change notification settings - Fork 105
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(IT Wallet): [SIW-1848] Remove IT Wallet trial system (#6487)
## Short description This PR completely removes the IT Wallet trial system, enabling the feature for everyone. ## List of changes proposed in this pull request - Removed trial system references from the .env files - Removed trial system selectors - Removed `ItwUpcomingWalletBanner` component - Refactored ITW banners for the wallet home screen - Updated components which was conditionally rendering using the Trial system active flag. - Updated tests ## How to test This PR must be tested in different conditions: ### a. IT Wallet feature is remotely disabled Use a proxy software (e.g., Proxyman) to mock the return value of the remote config and set the IT Wallet enable flag to `false`. ```json "itw": { "enabled": false, "min_app_version": { "ios": "2.67.0.2", "android": "2.67.0.2" }, "feedback_banner_visible": true } ``` Check that all elements related to the IT Wallet (e.g., banners, sections, ctas) are not visible throughout the app. ### b. IT Wallet feature is enabled, but a wallet is not yet been activated Set the IT Wallet enable flag back to `true`. Without activating the IT Wallet: 1. Navigate to the Messages Home screen. 2. Check the IT Wallet Discovery banner is visible. 3. Navigate to the Wallet Home screen. 4. Check the IT Wallet Discovery banner is visible here as well. 5. Check that the IT Wallet cards section is not rendered ### c. IT Wallet feature is enabled and there is a valid wallet active 1. Navigate to the Wallet Home screen. 2. Confirm the dedicated IT Wallet section is displayed correctly. 3. Verify that all related functionality is accessible and works as expected.
- Loading branch information
Showing
20 changed files
with
43 additions
and
550 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
export default { | ||
PREMIUM_MESSAGES_OPT_IN_ENABLED: "YES", | ||
SCAN_ADDITIONAL_BARCODES_ENABLED: "YES", | ||
ITW_TRIAL_ID: "baz" | ||
SCAN_ADDITIONAL_BARCODES_ENABLED: "YES" | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 0 additions & 35 deletions
35
ts/features/itwallet/common/components/ItwUpcomingWalletBanner.tsx
This file was deleted.
Oops, something went wrong.
92 changes: 0 additions & 92 deletions
92
ts/features/itwallet/common/components/__tests__/ItwUpcomingWalletBanner.test.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.