PIN-5088 Edit logic in createDescriptor #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taglioni-r
changed the title
galales
reviewed
Jul 16, 2024
| clonedDocuments <- Future.traverse(previousDescriptor.docs)(cloneDocument(UUIDSupplier.get(), _)) | ||
| eServiceDescriptorSeed = CatalogProcess.EServiceDescriptorSeed( | ||
| description = previousDescriptor.description, | ||
| audience = Seq(), |
There was a problem hiding this comment.
won't this fail for constraint on process?
There was a problem hiding this comment.
Interesting! So, since we don't have a default for that, we should decrease the minimum length to 0.
There was a problem hiding this comment.
it could be an option, but notice that in that case we need to validate the audience when publishing the descriptor (now it's not required because it is enforced by the spec).
I suppose the audience should not be copied from the previous descriptor?
There was a problem hiding this comment.
Update: the constraint is being edited (pagopa/interop-be-monorepo#762)
beetlecrunch
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[To be merged after pagopa/interop-be-monorepo/pull/739]
This pull request is for implementing the new logic inside
createDescriptor: retrieving previous values and copying documents.