Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Show app version on title screen #4344

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

fransdhinta
Copy link
Contributor

What are the changes the user will see?

  • Now the title screen will display the app version.

Why am I making these changes?

  • Because users need to know which version is running this game
  • As a user, I would be happy to know that the game version is updated, meaning the game is still maintained.
  • An issue mentioned this feature [Feature] Add version visual #3909 (comment)

What are the changes from a developer perspective?

  • Show app version below the title

Screenshots/Videos

before:
before
after:
after

How to test the changes?

Just load the game, go to title screen

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

src/ui/title-ui-handler.ts Outdated Show resolved Hide resolved
@flx-sta flx-sta added the UI/UX User interface/-experience related label Sep 20, 2024
@flx-sta flx-sta linked an issue Sep 20, 2024 that may be closed by this pull request
@DayKev DayKev added the Enhancement New feature or request label Sep 20, 2024
@DayKev DayKev merged commit 4160aef into pagefaultgames:beta Sep 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add version visual
4 participants