Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make money scaling linear #4340

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

Xavion3
Copy link
Collaborator

@Xavion3 Xavion3 commented Sep 20, 2024

What are the changes the user will see?

More money in the early to mid game, less money in the late game. Prices for shop items are slightly higher to compensate.

Why am I making these changes?

Discussed with balance

What are the changes from a developer perspective?

A new formula for money per wave

Screenshots/Videos

N/A

How to test the changes?

Do anything that earns money based on wave and compare the amount.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)

@Xavion3 Xavion3 added the Balance Team Specifically a balance team change label Sep 20, 2024
@Xavion3 Xavion3 requested a review from a team as a code owner September 20, 2024 05:49
@ben-lear
Copy link
Collaborator

Will this impact endless?

@Xavion3
Copy link
Collaborator Author

Xavion3 commented Sep 20, 2024

Yes, endless will find that items are much cheaper than before due to linear scaling instead of exponential scaling, and the golden punch is probably actually good.

@damocleas
Copy link
Collaborator

Will need testing further, I will post in the channel if it seems fine, shotgunned an approval automatically because cheese brain

@PigeonBar
Copy link
Contributor

PigeonBar commented Sep 20, 2024

This will have MASSIVE impacts on Endless players' ability to reroll in the shop. (Edit: For reference, reroll cost scales linearly both before and after this rework.) For example, on wave 4501, before this rebalance, a Relic Gold would give players enough money to reroll a very high number of times:

20240920 Endless Money Original

However, after implementing linear scaling, a Relic Gold will now only give around 7 times the amount of money needed for 1 reroll, which means that Endless players will be able to reroll much fewer times than before (and rerolls get even more expensive if you use Lock Capsule):

20240920 Endless Money Rebalance

This would mess up Endless strategy a lot, similarly to #3094. Is this intended?

@Xavion3
Copy link
Collaborator Author

Xavion3 commented Sep 20, 2024

Endless can still do a lot of rerolls, it's just less a single wave earns you enough money to reroll 5 times per wave for the next 100 waves.

Golden Punch actually becomes a viable item too and the new best way to make money, so comparing to relic golds is less accurate. A single golden punch proc is probably giving way more than a relic gold by the 4000s for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Team Specifically a balance team change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants