-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Balance] Remove Species Locks from Aura Wheel and Poison Puppeteer #4330
[Balance] Remove Species Locks from Aura Wheel and Poison Puppeteer #4330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting '// TODO' in string instead of comments will make display wrong.
json doesn't support comments, so moving these outside of the string would cause the code not to compile. These markers will be removed before this is taken out of draft, anyway |
@innerthunder |
Co-authored-by: Chapybara-jp <[email protected]>
Co-authored-by: Chapybara-jp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a haiku
The changes were made,
It was not hard to do it,
But it just got done.
Co-authored-by: DanStevensonx <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update zh_cn and zh_tw
Co-authored-by: btsrkex <[email protected]>
Co-authored-by: btsrkex <[email protected]>
What are the changes the user will see?
Why am I making these changes?
These species locks are unnecessarily restrictive with the existence of fusions, egg moves, and passive abilities.
What are the changes from a developer perspective?
data/move
: Removed Aura Wheel's condition requiring the user to be Morpeko (or a Morpeko fusion)data/ability
: Made Poison Puppeteer's effect attribute unconditional to the source's species.Screenshots/Videos
How to test the changes?
Using
src/overrides.ts
:Checklist
beta
as my base branchnpm run test
)