Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Balance] Remove Species Locks from Aura Wheel and Poison Puppeteer #4330

Merged
merged 24 commits into from
Sep 22, 2024

Conversation

innerthunder
Copy link
Collaborator

What are the changes the user will see?

  • Aura Wheel is now functional for species other than Morpeko (and fusions with Morpeko). It defaults to Electric type when used by Pokemon other than Morpeko
  • Poison Puppeteer is now functional for species other than Pecharunt

Why am I making these changes?

These species locks are unnecessarily restrictive with the existence of fusions, egg moves, and passive abilities.

What are the changes from a developer perspective?

  • data/move: Removed Aura Wheel's condition requiring the user to be Morpeko (or a Morpeko fusion)
  • data/ability: Made Poison Puppeteer's effect attribute unconditional to the source's species.
  • Localization changes:
    • Replaced reference to Pecharunt in Poison Puppeteer's description with "this Pokémon"
    • Updated Aura Wheel's description to reflect the changes to species-related conditions

Screenshots/Videos

How to test the changes?

Using src/overrides.ts:

  • Give a Pokemon other than Pecharunt Poison Puppeteer and Toxic. You should see that Toxic also confuses the target.
  • Give a Pokemon other than Morpeko Aura Wheel. You should see that the move doesn't fail and defaults to Electric type.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@innerthunder innerthunder added Move Affects a move Ability Affects an ability Localization Provides or updates translation efforts Balance Team Specifically a balance team change labels Sep 19, 2024
@innerthunder innerthunder requested review from a team as code owners September 19, 2024 20:18
damocleas
damocleas previously approved these changes Sep 19, 2024
Copy link
Contributor

@EnochG1 EnochG1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting '// TODO' in string instead of comments will make display wrong.

@innerthunder
Copy link
Collaborator Author

Putting '// TODO' in string instead of comments will make display wrong.

json doesn't support comments, so moving these outside of the string would cause the code not to compile. These markers will be removed before this is taken out of draft, anyway

@EnochG1
Copy link
Contributor

EnochG1 commented Sep 19, 2024

@innerthunder
Assuming this work is merged without the translator modifying the description,
I think it would be more appropriate to replace it with the changed English description.
(Wrong translation is worse than right English desc.)
Though you change to English desc, translators can check pre translation in diff.

src/locales/ja/ability.json Outdated Show resolved Hide resolved
src/locales/ja/move.json Outdated Show resolved Hide resolved
Adri1 and others added 2 commits September 21, 2024 02:05
Copy link
Contributor

@DanStevensonx DanStevensonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a haiku
The changes were made,
It was not hard to do it,
But it just got done.

src/locales/es/ability.json Outdated Show resolved Hide resolved
src/locales/es/move.json Outdated Show resolved Hide resolved
Copy link
Contributor

@btsrkex btsrkex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update zh_cn and zh_tw

src/locales/zh_TW/ability.json Outdated Show resolved Hide resolved
src/locales/zh_TW/move.json Outdated Show resolved Hide resolved
src/locales/zh_CN/ability.json Outdated Show resolved Hide resolved
src/locales/zh_CN/move.json Outdated Show resolved Hide resolved
@Adri1 Adri1 marked this pull request as ready for review September 22, 2024 14:26
@CodeTappert CodeTappert merged commit 3ef02c9 into pagefaultgames:beta Sep 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability Balance Team Specifically a balance team change Localization Provides or updates translation efforts Move Affects a move
Projects
None yet
Development

Successfully merging this pull request may close these issues.